* symtab.c (decode_line_1): Add comment about use of

	return_to_top_level directly instead of error.  Add comment saying
	that the '' should not be needed--that the completer should be fixed.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index af3ace2c95cb85932b9f93638443f1dab40ce50b..03fd96594c7e1a0105aa1367f8c74a0b8e95d86f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+Fri Nov 19 15:08:47 1993  Jim Kingdon  (kingdon@lioth.cygnus.com)
+
+       * symtab.c (decode_line_1): Add comment about use of
+       return_to_top_level directly instead of error.  Add comment saying
+       that the '' should not be needed--that the completer should be fixed.
+
 Fri Nov 19 11:00:33 1993  Kung Hsu  (kung@cirdan.cygnus.com)
 
        * symtab.c(decode_line_1): fix the inconsistency of setting

diff --git a/gdb/symtab.c b/gdb/symtab.c
index 32791492e2fc61e1613cc8ab1e187d89c0172f54..99811542f5b98edcfbe947f81f3a9dadfb1b936e 100644 (file)
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -1644,6 +1644,11 @@ build_canonical_line_spec (sal, symname, canonical)
    if no file is validly specified.  Callers must check that.
    Also, the line number returned may be invalid.  */
 
+/* We allow single quotes in various places.  This is a hideous
+   kludge, which exists because the completer can't yet deal with the
+   lack of single quotes.  FIXME: write a linespec_completer which we
+   can use as appropriate instead of make_symbol_completion_list.  */
+
 struct symtabs_and_lines
 decode_line_1 (argptr, funfirstline, default_symtab, default_line, canonical)
      char **argptr;
@@ -1742,6 +1747,8 @@ decode_line_1 (argptr, funfirstline, default_symtab, default_line, canonical)
          while(!++p && *p != '>');
          if (!p)
            {
+             /* FIXME: Why warning() and then return_to_top_level?
+                What's wrong with error()?  */
              warning("non-matching '<' and '>' in command");
              return_to_top_level (RETURN_ERROR);
            }