radv: remove useless sync after copying query results with compute
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Fri, 2 Nov 2018 11:20:48 +0000 (12:20 +0100)
committerSamuel Pitoiset <samuel.pitoiset@gmail.com>
Mon, 5 Nov 2018 08:47:55 +0000 (09:47 +0100)
The spec says:
   "vkCmdCopyQueryPoolResults is considered to be a transfer
    operation, and its writes to buffer memory must be synchronized
    using VK_PIPELINE_STAGE_TRANSFER_BIT and VK_ACCESS_TRANSFER_WRITE_BIT
    before using the results."

VK_PIPELINE_STAGE_TRANSFER_BIT will wait for compute to be idle,
while VK_ACCESS_TRANSFER_WRITE_BIT will invalidate both L1 vector
caches and L2. So, it's useless to set those flags internally.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
src/amd/vulkan/radv_query.c

index 57ea22fb8478b7ecd56a3bceee4647eadcae41f9..4153dc2f6797a4a9d26142796d6266e4d269f97d 100644 (file)
@@ -755,10 +755,6 @@ static void radv_query_shader(struct radv_cmd_buffer *cmd_buffer,
 
        radv_unaligned_dispatch(cmd_buffer, count, 1, 1);
 
-       cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_INV_GLOBAL_L2 |
-                                       RADV_CMD_FLAG_INV_VMEM_L1 |
-                                       RADV_CMD_FLAG_CS_PARTIAL_FLUSH;
-
        radv_meta_restore(&saved_state, cmd_buffer);
 }