sim-se: minor refactor for ProcessParams::create
authorBrandon Potter <brandon.potter@amd.com>
Thu, 8 Aug 2019 19:23:01 +0000 (15:23 -0400)
committerBrandon Potter <Brandon.Potter@amd.com>
Fri, 9 Aug 2019 01:42:14 +0000 (01:42 +0000)
Remove the nullptr initialization and change the message
for object file failure.

Change-Id: I14b80b47b65893c55810e7f715c1b8fc643c5125
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/19949
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/sim/process.cc

index 735933d018e394510409d07e5a108a6891ef1b7d..224152a329dcbea61996d5b5451f02d981d3e7d2 100644 (file)
@@ -529,8 +529,6 @@ Process::absolutePath(const std::string &filename, bool host_filesystem)
 Process *
 ProcessParams::create()
 {
-    Process *process = nullptr;
-
     // If not specified, set the executable parameter equal to the
     // simulated system's zeroth command line parameter
     if (executable == "") {
@@ -538,9 +536,9 @@ ProcessParams::create()
     }
 
     ObjectFile *obj_file = createObjectFile(executable);
-    fatal_if(!obj_file, "Can't load object file %s", executable);
+    fatal_if(!obj_file, "Cannot load object file %s.", executable);
 
-    process = ObjectFile::tryLoaders(this, obj_file);
+    Process *process = ObjectFile::tryLoaders(this, obj_file);
     fatal_if(!process, "Unknown error creating process object.");
 
     return process;