GDB testsuite: Re-enable -fdiagnostics-color=never

In August 2017 the GDB test suite was changed to always add the compile
option "-fdiagnostics-color=never", see:

  https://sourceware.org/ml/gdb-patches/2017-08/msg00150.html

Since this option is not understood by rustc, a commit from 09/2017
dropped its use in that case:

  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=5eb5f850
  ("Don't use -fdiagnostics-color=never for rustc")

But that change goes overboard and stops using the option for other
languages as well.  Thus compiler diagnostics written into gdb.log may
contain colored output again.  This is fixed.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (gdb_compile): Re-enable use of
	universal_compile_options for languages other than Rust.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index c3fc9c3efec15b50d38601fee55e86debec772c6..5040e14896b6a8347d3943375976e5f27177ff2d 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-18  Andreas Arnez  <arnez@linux.vnet.ibm.com>
+
+       * lib/gdb.exp (gdb_compile): Re-enable use of
+       universal_compile_options for languages other than Rust.
+
 2018-01-18  Andreas Arnez  <arnez@linux.vnet.ibm.com>
 
        * gdb.arch/s390-tdbregs.exp: Add the compile option -msoft-float.

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index a4bde724bec0c519d56b5d9931f145a0fc1e9807..7ee3a70fd2f9d7f11fcd63f78215aaf827219340 100644 (file)
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3504,12 +3504,12 @@ proc gdb_compile {source dest type options} {
 
     # Add platform-specific options if a shared library was specified using
     # "shlib=librarypath" in OPTIONS.
+    set new_options {}
     if {[lsearch -exact $options rust] != -1} {
        # -fdiagnostics-color is not a rustcc option.
     } else {
        set new_options [universal_compile_options]
     }
-    set new_options {}
     set shlib_found 0
     set shlib_load 0
     foreach opt $options {