svga: remove unneeded memset() call in draw_vgpu10()
authorBrian Paul <brianp@vmware.com>
Mon, 1 Aug 2016 22:31:13 +0000 (16:31 -0600)
committerBrian Paul <brianp@vmware.com>
Tue, 16 Aug 2016 14:24:52 +0000 (08:24 -0600)
All three fields of the vbuffer_attrs[] array are assigned in the following
loop.  The remaining elements of the array are not used.

Tested with full Piglit run, Heaven 4.0, etc.

Reviewed-by: Charmaine Lee <charmainel@vmware.com>
src/gallium/drivers/svga/svga_draw.c

index 14a74065b0ce6a08cb6e2ad2b8a054d52db84307..9d3f9eff29e843662a37bdcf4f75f7c1cba743a2 100644 (file)
@@ -533,11 +533,10 @@ draw_vgpu10(struct svga_hwtnl *hwtnl,
    {
       SVGA3dVertexBuffer vbuffer_attrs[PIPE_MAX_ATTRIBS];
 
-      memset(vbuffer_attrs, 0, sizeof(vbuffer_attrs));
-
       for (i = 0; i < vbuf_count; i++) {
          vbuffer_attrs[i].stride = hwtnl->cmd.vbufs[i].stride;
          vbuffer_attrs[i].offset = hwtnl->cmd.vbufs[i].buffer_offset;
+         vbuffer_attrs[i].sid = 0;
       }
 
       /* If we haven't yet emitted a drawing command or if any