2009-12-07 Tristan Gingold <gingold@adacore.com>

	* dbxread.c (dbx_symfile_read): No need to test mainline to call
	init_psymbol_list.
	* xcoffread.c (xcoff_initial_scan): Ditto;
	* coffread.c (coff_symfile_read): Remove call to init_psymbol_list.
	* elfread.c (elf_symfile_read): Ditto.
	* machoread.c (macho_symfile_read): Ditto.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 375f968331373d0f70c2615544af49f87b5cbb4b..075eee7d3c99350233e938a01aa6c83034925dea 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2009-12-07  Tristan Gingold  <gingold@adacore.com>
+
+       * dbxread.c (dbx_symfile_read): No need to test mainline to call
+       init_psymbol_list.
+       * xcoffread.c (xcoff_initial_scan): Ditto;
+       * coffread.c (coff_symfile_read): Remove call to init_psymbol_list.
+       * elfread.c (elf_symfile_read): Ditto.
+       * machoread.c (macho_symfile_read): Ditto.
+
 2009-12-04  Daniel Jacobowitz  <dan@codesourcery.com>
 
        * valops.c (value_struct_elt_for_reference): Do not rely on

diff --git a/gdb/coffread.c b/gdb/coffread.c
index 84edfc55ecc1007bd1c6285f6db19fdd3b1cd1cb..1f71db2b3001073f7b88b32f94ac7a75485a0a8a 100644 (file)
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -607,15 +607,6 @@ coff_symfile_read (struct objfile *objfile, int mainline)
   /* Free the installed minimal symbol data.  */
   do_cleanups (cleanup_minimal_symbols);
 
-  /* If we are reinitializing, or if we have not loaded syms yet,
-     empty the psymtab.  "mainline" is cleared so the *_read_psymtab
-     functions do not all re-initialize it.  */
-  if (mainline)
-    {
-      init_psymbol_list (objfile, 0);
-      mainline = 0;
-    }
-
   bfd_map_over_sections (abfd, coff_locate_sections, (void *) info);
 
   if (info->stabsects)

diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 771483a85bfc97495baddf22175a4858d1395d22..a1bd8e0bb13cbac6721de09886308aa8b9e9340c 100644 (file)
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -556,10 +556,8 @@ dbx_symfile_read (struct objfile *objfile, int mainline)
   if (val < 0)
     perror_with_name (objfile->name);
 
-  /* If we are reinitializing, or if we have never loaded syms yet, init */
-  if (mainline
-      || (objfile->global_psymbols.size == 0
-         &&  objfile->static_psymbols.size == 0))
+  /* Size the symbol table.  */
+  if (objfile->global_psymbols.size == 0 && objfile->static_psymbols.size == 0)
     init_psymbol_list (objfile, DBX_SYMCOUNT (objfile));
 
   symbol_size = DBX_SYMBOL_SIZE (objfile);

diff --git a/gdb/elfread.c b/gdb/elfread.c
index d143e63d2ba30acbf1c3f81c19e684493d2dde7f..f9052c1204d66b7d24fc5ed5036328701f166ebc 100644 (file)
--- a/gdb/elfread.c
+++ b/gdb/elfread.c
@@ -691,15 +691,6 @@ elf_symfile_read (struct objfile *objfile, int mainline)
   /* Now process debugging information, which is contained in
      special ELF sections. */
 
-  /* If we are reinitializing, or if we have never loaded syms yet,
-     set table to empty.  MAINLINE is cleared so that *_read_psymtab
-     functions do not all also re-initialize the psymbol table. */
-  if (mainline)
-    {
-      init_psymbol_list (objfile, 0);
-      mainline = 0;
-    }
-
   /* We first have to find them... */
   bfd_map_over_sections (abfd, elf_locate_sections, (void *) & ei);
 

diff --git a/gdb/machoread.c b/gdb/machoread.c
index 8ff899be67b7ec6b507beb366598e41a9b21031f..e82f12fe0058ea1f9aa8ef268e9f1fe74ab32495 100644 (file)
--- a/gdb/machoread.c
+++ b/gdb/machoread.c
@@ -649,11 +649,6 @@ macho_symfile_read (struct objfile *objfile, int mainline)
        }
     }
 
-  /* If we are reinitializing, or if we have never loaded syms yet,
-     set table to empty.  */
-  if (mainline)
-    init_psymbol_list (objfile, 0);
-
   if (dwarf2_has_info (objfile))
     {
       /* DWARF 2 sections */

diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index a93fbd2f23f4d6cc780d5e3ff321309a72b05925..35d8f1ddcaf41e67c581641b7b81bd023a1ff76b 100644 (file)
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -2948,9 +2948,7 @@ xcoff_initial_scan (struct objfile *objfile, int mainline)
     perror_with_name (_("reading symbol table"));
 
   /* If we are reinitializing, or if we have never loaded syms yet, init */
-  if (mainline
-      || (objfile->global_psymbols.size == 0
-         && objfile->static_psymbols.size == 0))
+  if (objfile->global_psymbols.size == 0 && objfile->static_psymbols.size == 0)
     /* I'm not sure how how good num_symbols is; the rule of thumb in
        init_psymbol_list was developed for a.out.  On the one hand,
        num_symbols includes auxents.  On the other hand, it doesn't