problem sourcing GDB script in interactive-mode on

When interactive-mode is not auto, GDB always uses that setting to
determine whether to act as if the input stream is a terminal or not.
However, this setting should only be honored if the input stream is
the standard input stream.  Otherwise, we run into trouble while
source-ing a GDB script, as shown below (on x86_64-linux):

        % cat script
        print 1
        print 2
        % gdb  -q
        (gdb) set interactive-mode on
        (gdb) source script
        (gdb) print 3
        $1 = 3

The lack of output and the fact that the "print 3" command returned
a value saved in $1 (as opposed to $3) indicates that the script was
not even evaluated at all.

gdb/ChangeLog:

        * top.c (input_from_terminal_p): Restrict the use of interactive_mode
        to the case where instream is stdin.

gdb/testsuite/ChangeLog:

        * gdb.base/interact.exp: New testcase.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a23aab91b0d9fb470c4feccd4aa5c679d5e56209..e8ba178b788efc5bc3548de657f93f001b94ff68 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2011-01-13  Joel Brobecker  <brobecker@adacore.com>
+
+       * top.c (input_from_terminal_p): Restrict the use of interactive_mode
+       to the case where instream is stdin.
+
 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
 
        * ia64-tdep.h (struct regcache): Forward declare.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index f6577c7a35af74a40091feff66a14b066be7ccfb..89265272cb46ee8434e7d94447745bf1f4900163 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2011-01-13  Joel Brobecker  <brobecker@adacore.com>
+
+       * gdb.base/interact.exp: New testcase.
+
 2011-01-12  Tom Tromey  <tromey@redhat.com>
 
        * gdb.mi/gdb2549.exp: Update for error message changes.

diff --git a/gdb/testsuite/gdb.base/interact.exp b/gdb/testsuite/gdb.base/interact.exp
new file mode 100644 (file)
index 0000000..1f15fd8
--- /dev/null
+++ b/gdb/testsuite/gdb.base/interact.exp
@@ -0,0 +1,48 @@
+# Copyright 2011 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Create a GDB script that we can source.  The script needs to generate
+# some output, to allow us to verify that it is executed properly.
+set fd [open "zzz-gdbscript" "w"]
+puts $fd "print 1"
+puts $fd "print 2"
+close $fd
+
+# The expected output from the script...
+set script_output "\\$\[0-9\]+ = 1\[\r\n\]+\\$\[0-9\]+ = 2.*"
+
+# Start a fresh GDB.  We don't need an executable for this test, so
+# nothing else to do in terms of testcase setup.
+gdb_exit
+gdb_start
+
+# Test sourcing of the script with interactive mode `auto'
+gdb_test_no_output "set interactive-mode auto"
+gdb_test "source zzz-gdbscript" "$script_output" \
+         "source script with interactive-mode auto"
+gdb_test "print 3" "= 3" "sanity check with interactive-mode auto"
+
+# Test sourcing of the script with interactive mode `on'
+gdb_test_no_output "set interactive-mode on"
+gdb_test "source zzz-gdbscript" "$script_output" \
+         "source script with interactive-mode on"
+gdb_test "print 4" "= 4" "sanity check with interactive-mode on"
+
+# Test sourcing of the script with interactive mode `of'
+gdb_test_no_output "set interactive-mode off"
+gdb_test "source zzz-gdbscript" "$script_output" \
+         "source script with interactive-mode off"
+gdb_test "print 5" "= 5" "sanity check with interactive-mode off"
+

diff --git a/gdb/top.c b/gdb/top.c
index d974897ec97d7059a9fbe3827360ee5347baf141..bba1a2ddf5fb3a3e39fdbbb0dc67bce3702f14ae 100644 (file)
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1292,7 +1292,7 @@ show_interactive_mode (struct ui_file *file, int from_tty,
 int
 input_from_terminal_p (void)
 {
-  if (interactive_mode != AUTO_BOOLEAN_AUTO)
+  if (interactive_mode != AUTO_BOOLEAN_AUTO && instream == stdin)
     return interactive_mode == AUTO_BOOLEAN_TRUE;
 
   if (batch_flag)