i965/blorp: Set the dynamic state upper bound.
authorPaul Berry <stereotype441@gmail.com>
Tue, 22 May 2012 23:16:43 +0000 (16:16 -0700)
committerPaul Berry <stereotype441@gmail.com>
Fri, 25 May 2012 15:45:11 +0000 (08:45 -0700)
We know from previous bug fixes (commits
c25e5300cba7628b58df93ead14ebc3cc32f338c and
b2ace06cbbbb1021e2d7ace12a985c6406821939) that texture border color
doesn't work if the dynamic state upper bound is set to 0.  Although
the blorp engine doesn't make use of texture borders, it seems like we
ought to err on the safe side and set this value properly.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i965/gen6_blorp.cpp

index 4e21ddfe4cac35d96b18c3367c54399f699b9c4a..601bc9bbcd09a6292ea7fb7018945798d71ffa71 100644 (file)
@@ -136,7 +136,12 @@ gen6_blorp_emit_state_base_address(struct brw_context *brw,
       OUT_BATCH(1); /* InstructionBaseAddress */
    }
    OUT_BATCH(1); /* GeneralStateUpperBound */
-   OUT_BATCH(1); /* DynamicStateUpperBound */
+   /* Dynamic state upper bound.  Although the documentation says that
+    * programming it to zero will cause it to be ignored, that is a lie.
+    * If this isn't programmed to a real bound, the sampler border color
+    * pointer is rejected, causing border color to mysteriously fail.
+    */
+   OUT_BATCH(0xfffff001);
    OUT_BATCH(1); /* IndirectObjectUpperBound*/
    OUT_BATCH(1); /* InstructionAccessUpperBound */
    ADVANCE_BATCH();