radv: Do not setup attachments without a framebuffer.

Test that found this: dEQP-VK.geometry.layered.1d_array.secondary_cmd_buffer

Fixes: 49e6c2fb78c "radv: Store color/depth surface info in attachment info instead of framebuffer."
Reviewed-by: Dave Airlie <airlied@redhat.com>

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 55b7a0a505539ace1184425c8cf9949c80db2f33..187e8c5c2520c9e3603fcab976d2ff56000f3f26 100644 (file)
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -3207,9 +3207,11 @@ VkResult radv_BeginCommandBuffer(
                struct radv_subpass *subpass =
                        &cmd_buffer->state.pass->subpasses[pBeginInfo->pInheritanceInfo->subpass];
 
-               result = radv_cmd_state_setup_attachments(cmd_buffer, cmd_buffer->state.pass, NULL);
-               if (result != VK_SUCCESS)
-                       return result;
+               if (cmd_buffer->state.framebuffer) {
+                       result = radv_cmd_state_setup_attachments(cmd_buffer, cmd_buffer->state.pass, NULL);
+                       if (result != VK_SUCCESS)
+                               return result;
+               }
 
                radv_cmd_buffer_set_subpass(cmd_buffer, subpass);
        }