ice40_wrapcarry to really preserve attributes via -unwrap option
authorEddie Hung <eddie@fpgeh.com>
Mon, 9 Dec 2019 19:48:28 +0000 (11:48 -0800)
committerEddie Hung <eddie@fpgeh.com>
Mon, 9 Dec 2019 19:48:28 +0000 (11:48 -0800)
passes/pmgen/ice40_wrapcarry.cc
techlibs/ice40/cells_map.v
techlibs/ice40/synth_ice40.cc
tests/arch/ice40/ice40_wrapcarry.ys [new file with mode: 0644]
tests/arch/ice40/wrapcarry.ys [deleted file]

index 8b3cf38bbb4933b1dc12ed41317f3832f3ee656a..522c8c363e05c3a70f68258b47d314419207f0e0 100644 (file)
@@ -50,11 +50,13 @@ void create_ice40_wrapcarry(ice40_wrapcarry_pm &pm)
        cell->setPort("\\O", st.lut->getPort("\\O"));
        cell->setParam("\\LUT", st.lut->getParam("\\LUT_INIT"));
 
-       cell->attributes = std::move(st.carry->attributes);
-       auto it = cell->attributes.find(ID::keep);
-       if (it != cell->attributes.end() && !it->second.as_bool())
-               cell->attributes.erase(it);
-       cell->attributes.insert(st.lut->attributes.begin(), st.lut->attributes.end());
+       for (const auto &a : st.carry->attributes)
+               cell->attributes[stringf("\\SB_CARRY.%s", a.first.c_str())] = a.second;
+       for (const auto &a : st.lut->attributes)
+               cell->attributes[stringf("\\SB_LUT4.%s", a.first.c_str())] = a.second;
+       cell->attributes[ID(SB_LUT4.name)] = Const(st.lut->name.str());
+       if (st.carry->get_bool_attribute(ID::keep) || st.lut->get_bool_attribute(ID::keep))
+               cell->attributes[ID::keep] = true;
 
        pm.autoremove(st.carry);
        pm.autoremove(st.lut);
@@ -68,33 +70,69 @@ struct Ice40WrapCarryPass : public Pass {
                log("\n");
                log("    ice40_wrapcarry [selection]\n");
                log("\n");
-               log("Wrap manually instantiated SB_CARRY cells, along with their associated SB_LUTs,\n");
+               log("Wrap manually instantiated SB_CARRY cells, along with their associated SB_LUT4s,\n");
                log("into an internal $__ICE40_CARRY_WRAPPER cell for preservation across technology\n");
-               log("mapping.");
+               log("mapping.\n");
                log("\n");
-               log("Attributes on both cells will be merged, with SB_CARRY attributes having priority\n");
-               log("over SB_LUT4 attributes, except when (* keep *) attributes present on the SB_CARRY4\n");
-               log("that logically evaluate to false will be dropped (thus allowing the keep attribute,\n");
-               log("if any, on the SB_LUT4 to be adopted).\n");
+               log("Attributes on both cells will have their names prefixed with 'SB_CARRY.' or\n");
+               log("'SB_LUT4.' and attached to the wrapping cell.\n");
+               log("A (* keep *) attribute on either cell will be logically OR-ed together.\n");
+               log("\n");
+               log("    -unwrap\n");
+               log("        unwrap $__ICE40_CARRY_WRAPPER cells back into SB_CARRYs and SB_LUT4s,\n");
+               log("        including restoring their attributes.\n");
                log("\n");
        }
        void execute(std::vector<std::string> args, RTLIL::Design *design) YS_OVERRIDE
        {
+               bool unwrap = false;
+
                log_header(design, "Executing ICE40_WRAPCARRY pass (wrap carries).\n");
 
                size_t argidx;
                for (argidx = 1; argidx < args.size(); argidx++)
                {
-                       // if (args[argidx] == "-singleton") {
-                       //      singleton_mode = true;
-                       //      continue;
-                       // }
+                       if (args[argidx] == "-unwrap") {
+                               unwrap = true;
+                               continue;
+                       }
                        break;
                }
                extra_args(args, argidx, design);
 
-               for (auto module : design->selected_modules())
-                       ice40_wrapcarry_pm(module, module->selected_cells()).run_ice40_wrapcarry(create_ice40_wrapcarry);
+               for (auto module : design->selected_modules()) {
+                       if (!unwrap)
+                               ice40_wrapcarry_pm(module, module->selected_cells()).run_ice40_wrapcarry(create_ice40_wrapcarry);
+                       else {
+                               for (auto cell : module->selected_cells()) {
+                                       if (cell->type != ID($__ICE40_CARRY_WRAPPER))
+                                               continue;
+
+                                       auto carry = module->addCell(NEW_ID, ID(SB_CARRY));
+                                       carry->setPort(ID(I0), cell->getPort(ID(A)));
+                                       carry->setPort(ID(I1), cell->getPort(ID(B)));
+                                       carry->setPort(ID(CI), cell->getPort(ID(CO)));
+                                       module->swap_names(carry, cell);
+                                       auto lut = module->addCell(cell->attributes.at(ID(SB_LUT4.name)).decode_string(), ID(SB_LUT4));
+                                       lut->setParam(ID(WIDTH), 4);
+                                       lut->setParam(ID(LUT), cell->getParam(ID(LUT)));
+                                       lut->setPort(ID(A), { cell->getPort(ID(I0)), cell->getPort(ID(A)), cell->getPort(ID(B)), cell->getPort(ID(I3)) });
+                                       lut->setPort(ID(Y), cell->getPort(ID(O)));
+
+                                       for (const auto &a : cell->attributes)
+                                               if (a.first.begins_with("\\SB_CARRY.\\"))
+                                                       carry->attributes[a.first.c_str() + strlen("\\SB_CARRY.")] = a.second;
+                                               else if (a.first.begins_with("\\SB_LUT4.\\"))
+                                                       lut->attributes[a.first.c_str() + strlen("\\SB_LUT4.")] = a.second;
+                                               else if (a.first.in(ID(SB_LUT4.name), ID::keep))
+                                                       continue;
+                                               else
+                                                       log_abort();
+
+                                       module->remove(cell);
+                               }
+                       }
+               }
        }
 } Ice40WrapCarryPass;
 
index efd763ef6f9c108c3eeac1b54df01c7ce0ddadc2..759549e30cc183bb662c805fa86863f3e6fce1c3 100644 (file)
@@ -61,22 +61,3 @@ module \$lut (A, Y);
   endgenerate
 endmodule
 `endif
-
-`ifndef NO_ADDER
-module \$__ICE40_CARRY_WRAPPER (output CO, O, input A, B, CI, I0, I3);
-  parameter LUT = 0;
-  SB_CARRY _TECHMAP_REPLACE_ (
-    .I0(A),
-    .I1(B),
-    .CI(CI),
-    .CO(CO)
-  );
-  \$lut #(
-    .WIDTH(4),
-    .LUT(LUT)
-  ) lut (
-    .A({I0,A,B,I3}),
-    .Y(O)
-  );
-endmodule
-`endif
index 901194b06385bd9ff7bfe0931e055b6d45598000..ed7a16c088d3751230e2c1ff3b00b2f262b52b3e 100644 (file)
@@ -363,6 +363,7 @@ struct SynthIce40Pass : public ScriptPass
                                else
                                        run(abc + " -dress -lut 4", "(skip if -noabc)");
                        }
+                       run("ice40_wrapcarry -unwrap");
                        run("techmap -D NO_LUT -map +/ice40/cells_map.v");
                        run("clean");
                        run("opt_lut -dlogic SB_CARRY:I0=2:I1=1:CI=0");
diff --git a/tests/arch/ice40/ice40_wrapcarry.ys b/tests/arch/ice40/ice40_wrapcarry.ys
new file mode 100644 (file)
index 0000000..fb9fccc
--- /dev/null
@@ -0,0 +1,54 @@
+read_verilog <<EOT
+module top(input A, B, CI, output O, CO);
+       SB_CARRY carry (
+               .I0(A),
+               .I1(B),
+               .CI(CI),
+               .CO(CO)
+       );
+       SB_LUT4 #(
+               .LUT_INIT(16'b 0110_1001_1001_0110)
+       ) adder (
+               .I0(1'b0),
+               .I1(A),
+               .I2(B),
+               .I3(1'b0),
+               .O(O)
+       );
+endmodule
+EOT
+
+ice40_wrapcarry
+select -assert-count 1 t:$__ICE40_CARRY_WRAPPER
+
+design -reset
+read_verilog <<EOT
+module top(input A, B, CI, output O, CO);
+    (* foo = "bar", answer = 42, keep=0 *)
+       SB_CARRY carry (
+               .I0(A),
+               .I1(B),
+               .CI(CI),
+               .CO(CO)
+       );
+    (* keep, blah="blah", answer = 43 *)
+       SB_LUT4 #(
+               .LUT_INIT(16'b 0110_1001_1001_0110)
+       ) adder (
+               .I0(1'b0),
+               .I1(A),
+               .I2(B),
+               .I3(1'b0),
+               .O(O)
+       );
+endmodule
+EOT
+
+ice40_wrapcarry
+select -assert-count 1 t:$__ICE40_CARRY_WRAPPER
+select -assert-count 0 t:* t:$__ICE40_CARRY_WRAPPER %d
+select -assert-count 1 a:keep=1 a:SB_CARRY.\foo=bar %i a:SB_CARRY.\answer=42 %i a:SB_LUT4.\blah=blah %i a:SB_LUT4.\answer=43 %i
+
+ice40_wrapcarry -unwrap
+select -assert-count 1 c:carry a:src=<<EOT:3 %i a:keep=0 %i a:foo=bar %i a:answer=42 %i
+select -assert-count 1 c:adder a:src=<<EOT:10 %i a:keep=1 %i a:blah=blah %i a:answer=43 %i
diff --git a/tests/arch/ice40/wrapcarry.ys b/tests/arch/ice40/wrapcarry.ys
deleted file mode 100644 (file)
index 579335b..0000000
+++ /dev/null
@@ -1,52 +0,0 @@
-read_verilog <<EOT
-module top(input A, B, CI, output O, CO);
-       SB_CARRY carry (
-               .I0(A),
-               .I1(B),
-               .CI(CI),
-               .CO(CO)
-       );
-       SB_LUT4 #(
-               .LUT_INIT(16'b 0110_1001_1001_0110)
-       ) adder (
-               .I0(1'b0),
-               .I1(A),
-               .I2(B),
-               .I3(1'b0),
-               .O(O)
-       );
-endmodule
-EOT
-
-ice40_wrapcarry
-select -assert-count 1 t:$__ICE40_CARRY_WRAPPER
-
-design -reset
-read_verilog <<EOT
-module top(input A, B, CI, output O, CO);
-    (* foo = "bar", answer = 42, keep=0 *)
-       SB_CARRY carry (
-               .I0(A),
-               .I1(B),
-               .CI(CI),
-               .CO(CO)
-       );
-    (* keep, blah="blah", answer = 43 *)
-       SB_LUT4 #(
-               .LUT_INIT(16'b 0110_1001_1001_0110)
-       ) adder (
-               .I0(1'b0),
-               .I1(A),
-               .I2(B),
-               .I3(1'b0),
-               .O(O)
-       );
-endmodule
-EOT
-
-ice40_wrapcarry
-select -assert-count 1 t:$__ICE40_CARRY_WRAPPER
-select -assert-count 0 t:* t:$__ICE40_CARRY_WRAPPER %d
-select -assert-count 1 a:foo=bar a:answer=42 %i a:keep=1 %i a:blah=blah %i
-techmap -map +/ice40/cells_map.v
-#TODO: Check unwrapped attributes