Use more conservative fences on RISC-V

The RISC-V memory model is still in the process of being formally
specified, so for now we're going to be safe and add the I/O bits to
userspace fences because there's no way to know if userspace is touching
memory-mapped I/O regions at compile time.

This will have no impact on existing microarchitecutres because they
treat all fences conservatively.

gcc/ChangeLog:

2017-03-17  Palmer Dabbelt  <palmer@dabbelt.com>

        * config/riscv/riscv.c (riscv_print_operand): Use "fence
        iorw,ow".
        * config/riscv/sync.mc (mem_thread_fence_1): Use "fence
        iorw,iorw".

From-SVN: r246282

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 90c855632145c52ce6ebf5a520b3fecae3262b96..487a09be45bc71e975f8539b2606af177310b717 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2017-03-17  Palmer Dabbelt  <palmer@dabbelt.com>
+
+       * config/riscv/riscv.c (riscv_print_operand): Use "fence
+       iorw,ow".
+       * config/riscv/sync.mc (mem_thread_fence_1): Use "fence
+       iorw,iorw".
+
 2017-03-20  Marek Polacek  <polacek@redhat.com>
 
        PR sanitizer/80063

diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c
index 25cc8037a09cc4c00af4c8e46557bbb63c541995..fa93c3c32b2f2072ac2d04c6c6fcb0b3aee29746 100644 (file)
--- a/gcc/config/riscv/riscv.c
+++ b/gcc/config/riscv/riscv.c
@@ -2794,7 +2794,7 @@ riscv_print_operand (FILE *file, rtx op, int letter)
 
     case 'F':
       if (riscv_memmodel_needs_release_fence ((enum memmodel) INTVAL (op)))
-       fputs ("fence rw,w; ", file);
+       fputs ("fence iorw,ow; ", file);
       break;
 
     default:

diff --git a/gcc/config/riscv/sync.md b/gcc/config/riscv/sync.md
index 09970b9f36bc451aae92fede99fa59ede15899b0..cde19e3bed8262e3ea79b464f1afbc70c7cd3871 100644 (file)
--- a/gcc/config/riscv/sync.md
+++ b/gcc/config/riscv/sync.md
@@ -53,7 +53,7 @@
        (unspec:BLK [(match_dup 0)] UNSPEC_MEMORY_BARRIER))
    (match_operand:SI 1 "const_int_operand" "")] ;; model
   ""
-  "fence\trw,rw")
+  "fence\tiorw,iorw")
 
 ;; Atomic memory operations.