glx: Fix glXGetProcAddress() of global glX symbols post-automake conversion.

When a GL LD_PRELOAD library like apitrace was used,
glXGetProcAddress() would return the preload's symbols instead of
libGL's symbol, leading to infinite recursion when the returned
function was called.  This didn't hit apitrace on most apps because
who calls glXGetProcAddress() on the global functions.

The -Bsymbolic, which was present in mklib before automake conversion,
causes the glxcmds.c:GLX_functions table to be resolved at link time,
so that LD_PRELOADs don't affect it any more.

Fixes crashes when running wine under apitrace.

Tested-by: Matt Turner <mattst88@gmail.com>
Tested-by: Marek Olšák <maraeo@gmail.com>

diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am
index a11bd3ff011f09ff91b1ec569ae23046338fe47f..2e065885e5211499eebad5dc7df234110cb128fa 100644 (file)
--- a/src/glx/Makefile.am
+++ b/src/glx/Makefile.am
@@ -101,6 +101,7 @@ GL_LIBS = \
        $(GL_LIB_DEPS)
 
 GL_LDFLAGS = \
+       -Wl,-Bsymbolic \
        -version-number 1:2
 
 libGL_la_SOURCES = $(GL_FILES)