hsail: Get rid of an inert private member of StorageSpace.

The "segment" private element in this class was only ever set to zero
on construction, and then used to index into a list of segment names
to get the string "none" in a DPRINTF. If debugging was turned off,
there would be no consumers of that variable, and that upset g++. This
change removes the essentially useless variable, and also that bit of
text in the DPRINTF.

Change-Id: I3f85db4af5f0678768243daf84b8d698350af931
Reviewed-on: https://gem5-review.googlesource.com/9221
Reviewed-by: Anthony Gutierrez <anthony.gutierrez@amd.com>
Maintainer: Anthony Gutierrez <anthony.gutierrez@amd.com>

diff --git a/src/gpu-compute/hsail_code.cc b/src/gpu-compute/hsail_code.cc
index 59faa67e91e59b576fd2e7106a4914e939c6315e..99f4b3896944419291a91863d6d8aaae6e102ece 100644 (file)
--- a/src/gpu-compute/hsail_code.cc
+++ b/src/gpu-compute/hsail_code.cc
@@ -305,8 +305,8 @@ StorageSpace::addSymbol(const BrigDirectiveVariable *sym,
 
     nextOffset = offset + size;
 
-    DPRINTF(HSAILObject, "Adding %s SYMBOL %s size %d offset 0x%x, init: %d\n",
-            segmentNames[segment], sym_name, size, offset, sym->init);
+    DPRINTF(HSAILObject, "Adding SYMBOL %s size %d offset %#x, init: %d\n",
+            sym_name, size, offset, sym->init);
 
     StorageElement* se = new StorageElement(sym_name, offset, size, sym);
     elements.push_back(se);

diff --git a/src/gpu-compute/hsail_code.hh b/src/gpu-compute/hsail_code.hh
index d9fbcc5776f1a7d5f16f976f96ab6dc01db1ed10..991946197fc51104ddbf46260d413c1ea7ec8d07 100644 (file)
--- a/src/gpu-compute/hsail_code.hh
+++ b/src/gpu-compute/hsail_code.hh
@@ -245,11 +245,9 @@ class StorageSpace
     DirVarToSE_map elements_by_brigptr;
 
     uint64_t nextOffset;
-    Brig::BrigSegment segment;
 
   public:
-    StorageSpace(Brig::BrigSegment _class)
-        : nextOffset(0), segment(_class)
+    StorageSpace(Brig::BrigSegment _class) : nextOffset(0)
     {
     }