nir: Rename lower_double_pack to lower_64bit_pack
authorJason Ekstrand <jason.ekstrand@intel.com>
Wed, 15 Feb 2017 06:20:32 +0000 (22:20 -0800)
committerJason Ekstrand <jason.ekstrand@intel.com>
Fri, 17 Feb 2017 01:28:03 +0000 (17:28 -0800)
There's nothing "double" about it other than, perhaps, the fact that it
packs two 32-bit values.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/compiler/Makefile.sources
src/compiler/nir/nir.h
src/compiler/nir/nir_lower_64bit_packing.c [new file with mode: 0644]
src/compiler/nir/nir_lower_double_packing.c [deleted file]
src/mesa/drivers/dri/i965/brw_nir.c

index 1e8edc087434649b146eec5ceba631abc50cf4f1..643a0181d8c7872c491ae273d297a6e8c5b57a5e 100644 (file)
@@ -205,6 +205,7 @@ NIR_FILES = \
        nir/nir_liveness.c \
        nir/nir_loop_analyze.c \
        nir/nir_loop_analyze.h \
+       nir/nir_lower_64bit_packing.c \
        nir/nir_lower_alu_to_scalar.c \
        nir/nir_lower_atomics.c \
        nir/nir_lower_bitmap.c \
@@ -213,7 +214,6 @@ NIR_FILES = \
        nir/nir_lower_clip_cull_distance_arrays.c \
        nir/nir_lower_constant_initializers.c \
        nir/nir_lower_double_ops.c \
-       nir/nir_lower_double_packing.c \
        nir/nir_lower_drawpixels.c \
        nir/nir_lower_global_vars_to_local.c \
        nir/nir_lower_gs_intrinsics.c \
index d92e6eb110986bb8413a49d59eb90f9be69176b9..84451a17aad8c1829ff91bc251ac11fd7f317965 100644 (file)
@@ -2549,7 +2549,7 @@ typedef enum {
 } nir_lower_doubles_options;
 
 void nir_lower_doubles(nir_shader *shader, nir_lower_doubles_options options);
-void nir_lower_double_pack(nir_shader *shader);
+void nir_lower_64bit_pack(nir_shader *shader);
 
 bool nir_normalize_cubemap_coords(nir_shader *shader);
 
diff --git a/src/compiler/nir/nir_lower_64bit_packing.c b/src/compiler/nir/nir_lower_64bit_packing.c
new file mode 100644 (file)
index 0000000..f523ceb
--- /dev/null
@@ -0,0 +1,97 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include "nir.h"
+#include "nir_builder.h"
+
+/*
+ * lowers:
+ *
+ * packDouble2x32(foo) -> packDouble2x32Split(foo.x, foo.y)
+ * unpackDouble2x32(foo) -> vec2(unpackDouble2x32_x(foo), unpackDouble2x32_y(foo))
+ * packInt2x32(foo) -> packInt2x32Split(foo.x, foo.y)
+ * unpackInt2x32(foo) -> vec2(unpackInt2x32_x(foo), unpackInt2x32_y(foo))
+ */
+
+static nir_ssa_def *
+lower_pack_64(nir_builder *b, nir_ssa_def *src)
+{
+   return nir_pack_64_2x32_split(b, nir_channel(b, src, 0),
+                                    nir_channel(b, src, 1));
+}
+
+static nir_ssa_def *
+lower_unpack_64(nir_builder *b, nir_ssa_def *src)
+{
+   return nir_vec2(b, nir_unpack_64_2x32_split_x(b, src),
+                      nir_unpack_64_2x32_split_y(b, src));
+}
+
+static void
+lower_64bit_pack_impl(nir_function_impl *impl)
+{
+   nir_builder b;
+   nir_builder_init(&b, impl);
+
+   nir_foreach_block(block, impl) {
+      nir_foreach_instr_safe(instr, block) {
+         if (instr->type != nir_instr_type_alu)
+            continue;
+
+         nir_alu_instr *alu_instr = (nir_alu_instr *) instr;
+
+         if (alu_instr->op != nir_op_pack_64_2x32 &&
+             alu_instr->op != nir_op_unpack_64_2x32)
+            continue;
+
+         b.cursor = nir_before_instr(&alu_instr->instr);
+
+         nir_ssa_def *src = nir_ssa_for_alu_src(&b, alu_instr, 0);
+         nir_ssa_def *dest;
+
+         switch (alu_instr->op) {
+         case nir_op_pack_64_2x32:
+            dest = lower_pack_64(&b, src);
+            break;
+         case nir_op_unpack_64_2x32:
+            dest = lower_unpack_64(&b, src);
+            break;
+         default:
+            unreachable("Impossible opcode");
+         }
+
+         nir_ssa_def_rewrite_uses(&alu_instr->dest.dest.ssa, nir_src_for_ssa(dest));
+         nir_instr_remove(&alu_instr->instr);
+      }
+   }
+}
+
+void
+nir_lower_64bit_pack(nir_shader *shader)
+{
+   nir_foreach_function(function, shader) {
+      if (function->impl)
+         lower_64bit_pack_impl(function->impl);
+   }
+}
diff --git a/src/compiler/nir/nir_lower_double_packing.c b/src/compiler/nir/nir_lower_double_packing.c
deleted file mode 100644 (file)
index 61c4ea6..0000000
+++ /dev/null
@@ -1,98 +0,0 @@
-/*
- * Copyright © 2015 Intel Corporation
- *
- * Permission is hereby granted, free of charge, to any person obtaining a
- * copy of this software and associated documentation files (the "Software"),
- * to deal in the Software without restriction, including without limitation
- * the rights to use, copy, modify, merge, publish, distribute, sublicense,
- * and/or sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
- * IN THE SOFTWARE.
- *
- */
-
-#include "nir.h"
-#include "nir_builder.h"
-
-/*
- * lowers:
- *
- * packDouble2x32(foo) -> packDouble2x32Split(foo.x, foo.y)
- * unpackDouble2x32(foo) -> vec2(unpackDouble2x32_x(foo), unpackDouble2x32_y(foo))
- * packInt2x32(foo) -> packInt2x32Split(foo.x, foo.y)
- * unpackInt2x32(foo) -> vec2(unpackInt2x32_x(foo), unpackInt2x32_y(foo))
- */
-
-static nir_ssa_def *
-lower_pack_64(nir_builder *b, nir_ssa_def *src)
-{
-   return nir_pack_64_2x32_split(b, nir_channel(b, src, 0),
-                                    nir_channel(b, src, 1));
-}
-
-static nir_ssa_def *
-lower_unpack_64(nir_builder *b, nir_ssa_def *src)
-{
-   return nir_vec2(b, nir_unpack_64_2x32_split_x(b, src),
-                      nir_unpack_64_2x32_split_y(b, src));
-}
-
-static void
-lower_double_pack_impl(nir_function_impl *impl)
-{
-   nir_builder b;
-   nir_builder_init(&b, impl);
-
-   nir_foreach_block(block, impl) {
-      nir_foreach_instr_safe(instr, block) {
-         if (instr->type != nir_instr_type_alu)
-            continue;
-
-         nir_alu_instr *alu_instr = (nir_alu_instr *) instr;
-
-         if (alu_instr->op != nir_op_pack_64_2x32 &&
-             alu_instr->op != nir_op_unpack_64_2x32)
-            continue;
-
-         b.cursor = nir_before_instr(&alu_instr->instr);
-
-         nir_ssa_def *src = nir_ssa_for_alu_src(&b, alu_instr, 0);
-         nir_ssa_def *dest;
-
-         switch (alu_instr->op) {
-         case nir_op_pack_64_2x32:
-            dest = lower_pack_64(&b, src);
-            break;
-         case nir_op_unpack_64_2x32:
-            dest = lower_unpack_64(&b, src);
-            break;
-         default:
-            unreachable("Impossible opcode");
-         }
-
-         nir_ssa_def_rewrite_uses(&alu_instr->dest.dest.ssa, nir_src_for_ssa(dest));
-         nir_instr_remove(&alu_instr->instr);
-      }
-   }
-}
-
-void
-nir_lower_double_pack(nir_shader *shader)
-{
-   nir_foreach_function(function, shader) {
-      if (function->impl)
-         lower_double_pack_impl(function->impl);
-   }
-}
-
index 0a8d3a838b6dc42d998909826977f9465bdec638..74703490c91a49c0698114d3cbbc18771d3321db 100644 (file)
@@ -511,7 +511,7 @@ nir_optimize(nir_shader *nir, const struct brw_compiler *compiler,
                                nir_lower_dfract |
                                nir_lower_dround_even |
                                nir_lower_dmod);
-      OPT_V(nir_lower_double_pack);
+      OPT_V(nir_lower_64bit_pack);
    } while (progress);
 
    return nir;