[gdb/testsuite] Remove unnecessary perror in some test-cases

On openSUSE Tumbleweed I noticed:
...
UNTESTED: gdb.dwarf2/fission-absolute-dwo.exp: fission-absolute-dwo.exp
ERROR: failed to compile fission-absolute-dwo
...

The ERROR is unnecessary, given that an UNTESTED is already emitted.

Furthermore, it could be argued that it is incorrect because it's not a
testsuite error to not be able to compile something, and UNTESTED or
UNSUPPORTED is more appropriate.

Remove the perror call, likewise in fission-relative-dwo.exp.

Tested on x86_64-linux.

diff --git a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
index e243598841e62ff6a2df7589833dda71cefb3315..531502374087ad9c75f89bdc68a1ab09c1725d93 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
@@ -112,7 +112,6 @@ set object_file [standard_output_file ${testfile}.o]
 if { [build_executable_and_dwo_files "${testfile}.exp" ${binfile} {nodebug} \
          [list $asm_file {nodebug split-dwo} ${object_file}] \
          [list $srcfile {nodebug}]] } {
-    perror "failed to compile ${gdb_test_file_name}"
     return -1
 }
 

diff --git a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
index 62d7941258261682138d38f8e2c85919fd739454..3b548c4e8b5b1921c71af701b2cf04494b846899 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
@@ -109,7 +109,6 @@ set object_file [standard_output_file ${testfile}.o]
 if { [build_executable_and_dwo_files "${testfile}.exp" ${testfile} {nodebug} \
          [list $asm_file {nodebug split-dwo} ${object_file}] \
          [list $srcfile {nodebug}]] } {
-    perror "failed to compile ${gdb_test_file_name}"
     return -1
 }