Simplify psymbol_functions::expand_symtabs_matching

I noticed that psymbol_functions::expand_symtabs_matching calls
make_ignore_params once per psymtab that is matched.  This seems
possibly expensive, so this patch hoists the call out of the loop.

gdb/ChangeLog
2021-03-26  Tom Tromey  <tom@tromey.com>

	* psymtab.c (psymbol_functions::expand_symtabs_matching): Only
	call make_ignore_params once.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7955aa4c64ec15389242162f824f4bfdaf532b25..168cd5b9c0505a6677077fad774b031bd745ef7f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2021-03-26  Tom Tromey  <tom@tromey.com>
+
+       * psymtab.c (psymbol_functions::expand_symtabs_matching): Only
+       call make_ignore_params once.
+
 2021-03-26  Tom Tromey  <tom@tromey.com>
 
        * psymtab.c (psymbol_functions::expand_symtabs_matching): Remove

diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index 5a64166d9831b83c1e10d39622040f33183a150f..1ea7376a8c863c5608c00f92696dca30da1d3696 100644 (file)
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -1306,6 +1306,10 @@ psymbol_functions::expand_symtabs_matching
   for (partial_symtab *ps : require_partial_symbols (objfile))
     ps->searched_flag = PST_NOT_SEARCHED;
 
+  gdb::optional<lookup_name_info> psym_lookup_name;
+  if (lookup_name != nullptr)
+    psym_lookup_name = lookup_name->make_ignore_params ();
+
   for (partial_symtab *ps : m_partial_symtabs->range ())
     {
       QUIT;
@@ -1335,7 +1339,7 @@ psymbol_functions::expand_symtabs_matching
 
       if ((symbol_matcher == NULL && lookup_name == NULL)
          || recursively_search_psymtabs (ps, objfile, domain,
-                                         lookup_name->make_ignore_params (),
+                                         *psym_lookup_name,
                                          symbol_matcher))
        {
          struct compunit_symtab *symtab =