[arm] Fix assembler option rewrite alphabetical comparison

	* common/config/arm/arm-common.c (compare_opt_names): Add function
	comment.  Use strcmp instead of manual loop.

From-SVN: r255942

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index fd78d8938209c2690807b8a56b7a1797bbf714bc..59b19b9c305af70f68b0e2986f25879a3765569a 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2017-12-21  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
+
+       * common/config/arm/arm-common.c (compare_opt_names): Add function
+       comment.  Use strcmp instead of manual loop.
+
 2017-12-21  Martin Liska  <mliska@suse.cz>
 
        PR gcov-profile/83509

diff --git a/gcc/common/config/arm/arm-common.c b/gcc/common/config/arm/arm-common.c
index d6374276a109cb8bc0dbe8640af4accc57a81496..6a1683e38aef62ff197b64776483f1b0b70b08ef 100644 (file)
--- a/gcc/common/config/arm/arm-common.c
+++ b/gcc/common/config/arm/arm-common.c
@@ -116,14 +116,14 @@ arm_rewrite_mcpu (int argc, const char **argv)
   return arm_rewrite_selected_cpu (argv[argc - 1]);
 }
 
+/* Comparator for arm_rewrite_selected_arch.  Compare the two arch extension
+   strings FIRST and SECOND and return TRUE if FIRST is less than SECOND
+   alphabetically.  */
+
 static bool
 compare_opt_names (const char *first, const char *second)
 {
-  for (int i = 0; ; i++)
-    if (first[i] == 0
-       || first[i] < second[i])
-      return true;
-  return false;
+  return strcmp (first, second) <= 0;
 }
 
 /* Rewrite the architecture string for passing to the assembler.