libctf, link: fix ctf_link_write fd leak

We were leaking the fd on every invocation.

libctf/
	* ctf-link.c (ctf_link_write): Close the fd.

diff --git a/libctf/ChangeLog b/libctf/ChangeLog
index c3451ee5aa6c7323cb088415ce11db2a4c64fce8..848bc48b1e8131bf25456c8ffb564d67a134fdad 100644 (file)
--- a/libctf/ChangeLog
+++ b/libctf/ChangeLog
@@ -1,3 +1,7 @@
+2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
+
+       * ctf-link.c (ctf_link_write): Close the fd.
+
 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 
        * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.

diff --git a/libctf/ctf-link.c b/libctf/ctf-link.c
index 705701d0eb52fb1815c0344874ffe957dae7389e..fa15c9bf9bbe8717c5a8d8a2e223aecec4120a7d 100644 (file)
--- a/libctf/ctf-link.c
+++ b/libctf/ctf-link.c
@@ -1071,6 +1071,7 @@ ctf_link_write (ctf_file_t *fp, size_t *size, size_t threshold)
        free (arg.dynames[i]);
       free (arg.dynames);
     }
+  fclose (f);
   return buf;
 
  err_no: