ruby: clean up a few warnings

diff --git a/src/mem/ruby/buffers/MessageBuffer.cc b/src/mem/ruby/buffers/MessageBuffer.cc
index eeba0def2e2ef842ac91f58ba1c6f4de1f6f41d0..9b6fd712e8e5457786255300cad3a7a0b9ac047d 100644 (file)
--- a/src/mem/ruby/buffers/MessageBuffer.cc
+++ b/src/mem/ruby/buffers/MessageBuffer.cc
@@ -294,7 +294,7 @@ void MessageBuffer::pop()
 {
   DEBUG_MSG(QUEUE_COMP,MedPrio,"pop from " + m_name);
   assert(isReady());
-  Time ready_time = m_prio_heap.extractMin().m_time;
+  m_prio_heap.extractMin();
   // record previous size and time so the current buffer size isn't adjusted until next cycle
   if (m_time_last_time_pop < g_eventQueue_ptr->getTime()) {
     m_size_at_cycle_start = m_size;

diff --git a/src/mem/ruby/network/orion/NetworkPower.cc b/src/mem/ruby/network/orion/NetworkPower.cc
index 9d10d5136938acf1fabf4c76b050bdf23c712575..e9e1dc4abeecafba14c78290ec2cccd175069f62 100644 (file)
--- a/src/mem/ruby/network/orion/NetworkPower.cc
+++ b/src/mem/ruby/network/orion/NetworkPower.cc
@@ -159,7 +159,7 @@ double SIM_reg_stat_energy(power_array_info *info, power_array *arr, double n_re
 //crossbar
 double SIM_crossbar_stat_energy(power_crossbar *crsbar, double n_data)
 {
-  double Eavg = 0, Eatomic, Estatic;
+  double Eavg = 0, Eatomic;
 
   if (n_data > crsbar->n_out) {
     n_data = crsbar->n_out;

diff --git a/src/mem/ruby/network/simple/PerfectSwitch.cc b/src/mem/ruby/network/simple/PerfectSwitch.cc
index 02725148fbe965307210899ae6066c89a8bf99c0..59f1d85ca584027a3b6d96ff6cc0498f81bbd47a 100644 (file)
--- a/src/mem/ruby/network/simple/PerfectSwitch.cc
+++ b/src/mem/ruby/network/simple/PerfectSwitch.cc
@@ -134,7 +134,6 @@ void PerfectSwitch::wakeup()
   int highest_prio_vnet = m_virtual_networks-1;
   int lowest_prio_vnet = 0;
   int decrementer = 1;
-  bool schedule_wakeup = false;
   NetworkMessage* net_msg_ptr = NULL;
 
   // invert priorities to avoid starvation seen in the component network

diff --git a/src/mem/ruby/network/simple/Topology.cc b/src/mem/ruby/network/simple/Topology.cc
index 7c52af1ce72cfaf8036800eeba4c4b63518160e2..177bf3929f6d4ad04b4115c7e9ac57e8dd846ebd 100644 (file)
--- a/src/mem/ruby/network/simple/Topology.cc
+++ b/src/mem/ruby/network/simple/Topology.cc
@@ -57,7 +57,7 @@ static const int DEFAULT_BW_MULTIPLIER = 1;  // Just to be consistent with above
 // of the network.
 
 // Helper functions based on chapter 29 of Cormen et al.
-static Matrix extend_shortest_path(const Matrix& current_dist, Matrix& latencies, Matrix& inter_switches);
+static void extend_shortest_path(Matrix& current_dist, Matrix& latencies, Matrix& inter_switches);
 static Matrix shortest_path(const Matrix& weights, Matrix& latencies, Matrix& inter_switches);
 static bool link_is_shortest_path_to_node(SwitchID src, SwitchID next, SwitchID final, const Matrix& weights, const Matrix& dist);
 static NetDest shortest_path_to_node(SwitchID src, SwitchID next, const Matrix& weights, const Matrix& dist);

diff --git a/src/mem/ruby/profiler/Profiler.cc b/src/mem/ruby/profiler/Profiler.cc
index 558402bf575ce3da6cfc1991f4ada6113c72b782..07cbdcce78a8290807072341f3f7589af6fa38b9 100644 (file)
--- a/src/mem/ruby/profiler/Profiler.cc
+++ b/src/mem/ruby/profiler/Profiler.cc
@@ -707,7 +707,7 @@ void Profiler::profileConflictingRequests(const Address& addr)
   assert(addr == line_address(addr));
   Time last_time = m_ruby_start;
   if (m_conflicting_map_ptr->exist(addr)) {
-    Time last_time = m_conflicting_map_ptr->lookup(addr);
+    last_time = m_conflicting_map_ptr->lookup(addr);
   }
   Time current_time = g_eventQueue_ptr->getTime();
   assert (current_time - last_time > 0);

diff --git a/src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.cc b/src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.cc
index 0d5b48c34acfc3345112a5accccfacebf4ef6565..1c0435aca8b010d06ab4ac80652ce518155c00dc 100644 (file)
--- a/src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.cc
+++ b/src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.cc
@@ -141,6 +141,7 @@ void profileGetS(const Address& datablock, const Address& PC, const Set& owner,
 
 void profileOverflow(const Address & addr, MachineID mach)
 {
+#if 0
   if(mach.type == MACHINETYPE_L1CACHE_ENUM){
     // for L1 overflows
     int proc_num = L1CacheMachIDToProcessorNum(mach);
@@ -156,6 +157,7 @@ void profileOverflow(const Address & addr, MachineID mach)
       // g_system_ptr->getChip(chip_num)->m_L1Cache_xact_mgr_vec[p]->profileOverflow(addr, false);
     }
   }
+#endif
 }
 
 

diff --git a/src/mem/ruby/system/MemoryControl.cc b/src/mem/ruby/system/MemoryControl.cc
index eeb2f2fefc773d6d27b8b042e8dbc7770a38bec7..2f93d98d5132cd338583e56bc0cdb5a402a5cac6 100644 (file)
--- a/src/mem/ruby/system/MemoryControl.cc
+++ b/src/mem/ruby/system/MemoryControl.cc
@@ -258,7 +258,6 @@ void MemoryControl::enqueueMemRef (MemoryNode& memRef) {
   Time arrival_time = memRef.m_time;
   uint64 at = arrival_time;
   bool is_mem_read = memRef.m_is_mem_read;
-  bool dirtyWB = memRef.m_is_dirty_wb;
   physical_address_t addr = memRef.m_addr;
   int bank = getBank(addr);
   if (m_debug) {

diff --git a/src/mem/ruby/system/NodePersistentTable.cc b/src/mem/ruby/system/NodePersistentTable.cc
index 0edd66c6b7689de8dc0cdbfe9c5d3bad3919d087..4dd5c670f87fc56695bc1ec6c35a9af9c5f2cb24 100644 (file)
--- a/src/mem/ruby/system/NodePersistentTable.cc
+++ b/src/mem/ruby/system/NodePersistentTable.cc
@@ -181,7 +181,6 @@ int NodePersistentTable::countStarvingForAddress(const Address& address) const
 
 int NodePersistentTable::countReadStarvingForAddress(const Address& address) const
 {
-  int count = 0;
   if (m_map_ptr->exist(address)) {
     NodePersistentTableEntry& entry = m_map_ptr->lookup(address);
     return (entry.m_starving.count() - entry.m_request_to_write.count());

diff --git a/src/mem/ruby/system/PersistentTable.cc b/src/mem/ruby/system/PersistentTable.cc
index 146b91fedfce567a39d9a887711097a2ae99bb9b..7f07251ce661d4d663bdd736cdc83741c3bfa496 100644 (file)
--- a/src/mem/ruby/system/PersistentTable.cc
+++ b/src/mem/ruby/system/PersistentTable.cc
@@ -182,7 +182,6 @@ int PersistentTable::countStarvingForAddress(const Address& address) const
 
 int PersistentTable::countReadStarvingForAddress(const Address& address) const
 {
-  int count = 0;
   if (m_map_ptr->exist(address)) {
     PersistentTableEntry& entry = m_map_ptr->lookup(address);
     return (entry.m_starving.count() - entry.m_request_to_write.count());

diff --git a/src/mem/ruby/system/StoreBuffer.cc b/src/mem/ruby/system/StoreBuffer.cc
index 4d67e55a541e14fa2220a7cc54d6b69fa52b1c37..7f43771f3811770e6f1835993c14149593ecd3c5 100644 (file)
--- a/src/mem/ruby/system/StoreBuffer.cc
+++ b/src/mem/ruby/system/StoreBuffer.cc
@@ -210,7 +210,7 @@ void StoreBuffer::callBack(const Address& addr, DataBlock& data)
   assert(line_address(m_pending_address) == addr);
   assert(line_address(peek().m_subblock.getAddress()) == addr);
   CacheRequestType type = peek().m_type;
-  int threadID = peek().m_thread;
+  //int threadID = peek().m_thread;
   assert((type == CacheRequestType_ST) || (type == CacheRequestType_ATOMIC));
   m_pending = false;
 

diff --git a/src/mem/ruby/tester/DetermInvGenerator.cc b/src/mem/ruby/tester/DetermInvGenerator.cc
index 50d7162ab853d788f035ae92e72fe733e941c430..89d70d91a7a15d2466997e1f3dc17bc406c14c0c 100644 (file)
--- a/src/mem/ruby/tester/DetermInvGenerator.cc
+++ b/src/mem/ruby/tester/DetermInvGenerator.cc
@@ -112,8 +112,6 @@ void DetermInvGenerator::performCallback(NodeID proc, SubBlock& data)
 
   if (m_status == DetermInvGeneratorStatus_Load_Pending) {
     m_driver.recordLoadLatency(g_eventQueue_ptr->getTime() - m_last_transition);
-    NodeID firstByte = data.readByte();  // dummy read
-
     m_driver.loadCompleted(m_node, data.getAddress());
 
     if (!m_driver.isStoreReady(m_node, m_address))  {  // if we don't have to store, we are done for this transaction

diff --git a/src/mem/ruby/tester/DeterministicDriver.cc b/src/mem/ruby/tester/DeterministicDriver.cc
index 2ea82c77c60afb471796a37c505bd088f8e79dc5..bc27c2a355fb5f839c0089e6b6a2bf0a1e667c3b 100644 (file)
--- a/src/mem/ruby/tester/DeterministicDriver.cc
+++ b/src/mem/ruby/tester/DeterministicDriver.cc
@@ -253,7 +253,9 @@ void DeterministicDriver::checkForDeadlock()
   for (int processor=0; processor<size; processor++) {
     if ((current_time - m_last_progress_vector[processor]) > g_DEADLOCK_THRESHOLD) {
       WARN_EXPR(processor);
+#ifndef NDEBUG
       Sequencer* seq_ptr = g_system_ptr->getChip(processor/RubyConfig::numberOfProcsPerChip())->getSequencer(processor%RubyConfig::numberOfProcsPerChip());
+#endif
       assert(seq_ptr != NULL);
       //     if (seq_ptr->isRequestPending()) {
       //       WARN_EXPR(seq_ptr->pendingAddress());

diff --git a/src/mem/ruby/tester/SyntheticDriver.cc b/src/mem/ruby/tester/SyntheticDriver.cc
index f74b69d0ba5da8166e9ea5260a86af17d5a00dd3..946bb1db6bb00a1232abb48a573a54f1be0b7f75 100644 (file)
--- a/src/mem/ruby/tester/SyntheticDriver.cc
+++ b/src/mem/ruby/tester/SyntheticDriver.cc
@@ -175,7 +175,6 @@ Address SyntheticDriver::pickAddress(NodeID node)
 
   Address addr;
   // FIXME - make this a parameter of the workload
-  bool done = false;
   int lock_number = 0;
   int counter = 0;
   while (1) {
@@ -241,7 +240,9 @@ void SyntheticDriver::checkForDeadlock()
   for (int processor=0; processor<size; processor++) {
     if ((current_time - m_last_progress_vector[processor]) > g_DEADLOCK_THRESHOLD) {
       WARN_EXPR(processor);
+#ifndef NDEBUG
       Sequencer* seq_ptr = g_system_ptr->getChip(processor/RubyConfig::numberOfProcsPerChip())->getSequencer(processor%RubyConfig::numberOfProcsPerChip());
+#endif
       assert(seq_ptr != NULL);
       //     if (seq_ptr->isRequestPending()) {
       //       WARN_EXPR(seq_ptr->pendingAddress());