radv: Remove some intel comments from the resolve code.
authorBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Thu, 24 Aug 2017 22:26:44 +0000 (00:26 +0200)
committerBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Fri, 25 Aug 2017 20:47:49 +0000 (22:47 +0200)
These are clearly not applicable to radv.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/amd/vulkan/radv_meta_resolve.c
src/amd/vulkan/radv_meta_resolve_cs.c
src/amd/vulkan/radv_meta_resolve_fs.c

index 6023e0f89998262e7cfdea1c531d056f28dfbba2..dd811c2514282357d6e7f2d9e300531462809dce 100644 (file)
@@ -612,13 +612,6 @@ radv_cmd_buffer_resolve_subpass(struct radv_cmd_buffer *cmd_buffer)
 
                radv_cmd_buffer_set_subpass(cmd_buffer, &resolve_subpass, false);
 
-               /* Subpass resolves must respect the render area. We can ignore the
-                * render area here because vkCmdBeginRenderPass set the render area
-                * with 3DSTATE_DRAWING_RECTANGLE.
-                *
-                * XXX(chadv): Does the hardware really respect
-                * 3DSTATE_DRAWING_RECTANGLE when draing a 3DPRIM_RECTLIST?
-                */
                emit_resolve(cmd_buffer,
                             &(VkOffset2D) { 0, 0 },
                             &(VkExtent2D) { fb->width, fb->height });
index d20d04231ed6c32396481f775fe60c6b354f8a58..da6ca76b6d4fbb7db5de72024218fb29a881990f 100644 (file)
@@ -529,13 +529,6 @@ radv_cmd_buffer_resolve_subpass_cs(struct radv_cmd_buffer *cmd_buffer)
 
                radv_cmd_buffer_set_subpass(cmd_buffer, &resolve_subpass, false);
 
-               /* Subpass resolves must respect the render area. We can ignore the
-                * render area here because vkCmdBeginRenderPass set the render area
-                * with 3DSTATE_DRAWING_RECTANGLE.
-                *
-                * XXX(chadv): Does the hardware really respect
-                * 3DSTATE_DRAWING_RECTANGLE when draing a 3DPRIM_RECTLIST?
-                */
                emit_resolve(cmd_buffer,
                             src_iview,
                             dst_iview,
index 2f745f0ea09f2023a499ba0cb1863973034e302a..373dd9665a75efb4a0d665f22abd7b41017db73d 100644 (file)
@@ -633,13 +633,6 @@ radv_cmd_buffer_resolve_subpass_fs(struct radv_cmd_buffer *cmd_buffer)
 
                radv_cmd_buffer_set_subpass(cmd_buffer, &resolve_subpass, false);
 
-               /* Subpass resolves must respect the render area. We can ignore the
-                * render area here because vkCmdBeginRenderPass set the render area
-                * with 3DSTATE_DRAWING_RECTANGLE.
-                *
-                * XXX(chadv): Does the hardware really respect
-                * 3DSTATE_DRAWING_RECTANGLE when draing a 3DPRIM_RECTLIST?
-                */
                emit_resolve(cmd_buffer,
                             src_iview,
                             dest_iview,