i965: Fix AA Line Distance Mode in 3DSTATE_SF on Ivybridge.
authorKenneth Graunke <kenneth@whitecape.org>
Thu, 8 Nov 2012 12:13:26 +0000 (04:13 -0800)
committerKenneth Graunke <kenneth@whitecape.org>
Sat, 10 Nov 2012 20:14:23 +0000 (12:14 -0800)
We were accidentally setting bit 14 in DWord 2 (which is Reserved/MBZ)
rather than bit 14 in DWord 3 (which is AA Line Distance Mode).

There's also no reason to ever set it to legacy mode; the bit is only
used when drawing antialiased lines anyway.  Set it unconditionally.

NOTE: This is a candidate for stable branches.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
src/mesa/drivers/dri/i965/gen7_sf_state.c

index 871a8b753a3a2720b62923ecdb36ede8091560f1..28c650838448244a6ea9dc290fe222bc369ed8bf 100644 (file)
@@ -253,7 +253,6 @@ upload_sf_state(struct brw_context *brw)
    }
    if (ctx->Line.SmoothFlag) {
       dw2 |= GEN6_SF_LINE_AA_ENABLE;
-      dw2 |= GEN6_SF_LINE_AA_MODE_TRUE;
       dw2 |= GEN6_SF_LINE_END_CAP_WIDTH_1_0;
    }
    if (ctx->Line.StippleFlag && intel->is_haswell) {
@@ -264,10 +263,9 @@ upload_sf_state(struct brw_context *brw)
       dw2 |= GEN6_SF_MSRAST_ON_PATTERN;
 
    /* FINISHME: Last Pixel Enable?  Vertex Sub Pixel Precision Select?
-    * FINISHME: AA Line Distance Mode?
     */
 
-   dw3 = 0;
+   dw3 = GEN6_SF_LINE_AA_MODE_TRUE;
 
    /* _NEW_PROGRAM | _NEW_POINT */
    if (!(ctx->VertexProgram.PointSizeEnabled || ctx->Point._Attenuated))