Change objfile::partial_symtabs to be a unique_ptr

A plan I had a while ago was to write the DWARF index in a worker
thread.  This is why objfile::partial_symtabs is a shared_ptr.

However, it turned out that doing this required keeping the objfile
alive as well.  Now that objfiles are managed using shared_ptr,
there's no need for partial_symtabs to be one as well, so this patch
reverts that change.

gdb/ChangeLog
2019-12-12  Tom Tromey  <tom@tromey.com>

	* objfiles.h (struct objfile) <partial_symtabs>: Now a
	unique_ptr.

Change-Id: I3d7831006c40d4c8f3173ba51c0c1b0a32021ae5

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8c26bb06add7d6ffde035cfa4e68314c895a685b..ecd21247200688dc26a35a05139dcf799cff04ad 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-12  Tom Tromey  <tom@tromey.com>
+
+       * objfiles.h (struct objfile) <partial_symtabs>: Now a
+       unique_ptr.
+
 2019-12-12  Tom Tromey  <tom@tromey.com>
 
        * progspace.h (objfile_list): New typedef.

diff --git a/gdb/objfiles.h b/gdb/objfiles.h
index f0ee8037b6ddc374afef244479dafb71d57bdb15..9a433ddd7b043b4c7c1c137d395f93155b903bc6 100644 (file)
--- a/gdb/objfiles.h
+++ b/gdb/objfiles.h
@@ -518,7 +518,7 @@ public:
 
   /* The partial symbol tables.  */
 
-  std::shared_ptr<psymtab_storage> partial_symtabs;
+  std::unique_ptr<psymtab_storage> partial_symtabs;
 
   /* The object file's BFD.  Can be null if the objfile contains only
      minimal symbols, e.g. the run time common symbols for SunOS4.  */