PR gdb/20653 - small cleanup in string_to_explicit_location

This bug points out that string_to_explicit_location compares a char*
against '\0'; whereas comparing against NULL is more normal.

2016-10-05  Tom Tromey  <tom@tromey.com>

	PR breakpoints/20653:
	* location.c (string_to_explicit_location): Use NULL, not '\0'.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1fc318ef7b442f52a11686af704e0cd4783ba9f9..225bf7559006dd1a345a95c00735e8554a806efc 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-05  Tom Tromey  <tom@tromey.com>
+
+       PR breakpoints/20653:
+       * location.c (string_to_explicit_location): Use NULL, not '\0'.
+
 2016-10-05  Tom Tromey  <tom@tromey.com>
 
        PR symtab/20652:

diff --git a/gdb/location.c b/gdb/location.c
index 65116c732f7071444986c4b582580b7cc4622f0b..8dce21ada12b3f8cb4145d1af96e29efe378bda2 100644 (file)
--- a/gdb/location.c
+++ b/gdb/location.c
@@ -524,7 +524,7 @@ string_to_explicit_location (const char **argp,
      character is an explicit location.  "-p" is reserved, though,
      for probe locations.  */
   if (argp == NULL
-      || *argp == '\0'
+      || *argp == NULL
       || *argp[0] != '-'
       || !isalpha ((*argp)[1])
       || ((*argp)[0] == '-' && (*argp)[1] == 'p'))