re PR preprocessor/33305 (We should warn about empty macro arguments)

2008-06-13  Andrew Haley  <aph@redhat.com>

        PR preprocessor/33305
        * macro.c (replace_args): Print a warning for empty macro
        arguments in C89 and C++.

From-SVN: r137414

diff --git a/libcpp/ChangeLog b/libcpp/ChangeLog
index 7f069414f7e844498745451896e71d035af8ab41..2d29a30956635804c836fcce290954ed07fe306d 100644 (file)
--- a/libcpp/ChangeLog
+++ b/libcpp/ChangeLog
@@ -1,3 +1,9 @@
+2008-06-13  Andrew Haley  <aph@redhat.com>
+
+       PR preprocessor/33305
+       * macro.c (replace_args): Print a warning for empty macro
+       arguments in C89 and C++.
+
 2008-06-17  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
 
        * Makefile.in ($(srcdir)/aclocal.m4): Update dependencies.

diff --git a/libcpp/macro.c b/libcpp/macro.c
index 016754bc9529566ce2929bd1801bf13942b2f39c..edc2856551ad899c251f391bfb3a47c348072354 100644 (file)
--- a/libcpp/macro.c
+++ b/libcpp/macro.c
@@ -1009,6 +1009,17 @@ replace_args (cpp_reader *pfile, cpp_hashnode *node, cpp_macro *macro, macro_arg
          if (src->flags & PASTE_LEFT)
            paste_flag = dest - 1;
        }
+      else if (CPP_PEDANTIC (pfile) && ! macro->syshdr
+              && ! CPP_OPTION (pfile, c99)
+              && ! cpp_in_system_header (pfile))
+       {
+         cpp_error (pfile, CPP_DL_PEDWARN,
+                    "invoking macro %s argument %d: "
+                    "empty macro arguments are undefined"
+                    " in ISO C90 and ISO C++98",
+                    NODE_NAME (node),
+                    src->val.arg_no);
+       }
 
       /* Avoid paste on RHS (even case count == 0).  */
       if (!pfile->state.in_directive && !(src->flags & PASTE_LEFT))