Fix memory leak in bfd_get_debug_link_info_1

	* opncls.c (bfd_get_alt_debug_link_info): Don't bother freeing
	after bfd_malloc_and_get_section failure.
	(get_build_id): Likewise.
	(bfd_get_debug_link_info_1): Likewise.  Free section contents
	when crc not present.
	* section.c (bfd_malloc_and_get_section): Document that the
	buffer is NULL on error return.

diff --git a/bfd/opncls.c b/bfd/opncls.c
index abea464baa4735d4db8cd2a1503fb7afc81d0d77..81e124457e991f505ba56cafe8284155af52b8fe 100644 (file)
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -1211,10 +1211,7 @@ bfd_get_debug_link_info_1 (bfd *abfd, void *crc32_out)
     return NULL;
 
   if (!bfd_malloc_and_get_section (abfd, sect, &contents))
-    {
-      free (contents);
-      return NULL;
-    }
+    return NULL;
 
   /* CRC value is stored after the filename, aligned up to 4 bytes.  */
   name = (char *) contents;
@@ -1222,7 +1219,10 @@ bfd_get_debug_link_info_1 (bfd *abfd, void *crc32_out)
   crc_offset = strnlen (name, size) + 1;
   crc_offset = (crc_offset + 3) & ~3;
   if (crc_offset + 4 > size)
-    return NULL;
+    {
+      free (name);
+      return NULL;
+    }
 
   *crc32 = bfd_get_32 (abfd, contents + crc_offset);
   return name;
@@ -1297,10 +1297,7 @@ bfd_get_alt_debug_link_info (bfd * abfd, bfd_size_type *buildid_len,
     return NULL;
 
   if (!bfd_malloc_and_get_section (abfd, sect, & contents))
-    {
-      free (contents);
-      return NULL;
-    }
+    return NULL;
 
   /* BuildID value is stored after the filename.  */
   name = (char *) contents;
@@ -1817,10 +1814,7 @@ get_build_id (bfd *abfd)
     }
 
   if (!bfd_malloc_and_get_section (abfd, sect, & contents))
-    {
-      free (contents);
-      return NULL;
-    }
+    return NULL;
 
   /* FIXME: Paranoia - allow for compressed build-id sections.
      Maybe we should complain if this size is different from

diff --git a/bfd/section.c b/bfd/section.c
index 3b1993b60a5768383721b274a875a27a55440f62..1e7e8ac75227cd08cdd7040ba069f50912a760c5 100644 (file)
--- a/bfd/section.c
+++ b/bfd/section.c
@@ -1600,6 +1600,8 @@ SYNOPSIS
 DESCRIPTION
        Read all data from @var{section} in BFD @var{abfd}
        into a buffer, *@var{buf}, malloc'd by this function.
+       Return @code{true} on success, @code{false} on failure in which
+       case *@var{buf} will be NULL.
 */
 
 bool