radv: use vk_zalloc instead of vk_alloc+memset
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Fri, 10 Nov 2017 08:18:02 +0000 (09:18 +0100)
committerSamuel Pitoiset <samuel.pitoiset@gmail.com>
Mon, 13 Nov 2017 10:05:35 +0000 (11:05 +0100)
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
src/amd/vulkan/radv_cmd_buffer.c
src/amd/vulkan/radv_device.c
src/amd/vulkan/radv_image.c
src/amd/vulkan/radv_pipeline.c

index 8d69d2935a0cf9e9a473d01f9f1779560513d77e..8fa935131f27d05a3324b5abe5ba078785649c74 100644 (file)
@@ -198,12 +198,11 @@ static VkResult radv_create_cmd_buffer(
 {
        struct radv_cmd_buffer *cmd_buffer;
        unsigned ring;
-       cmd_buffer = vk_alloc(&pool->alloc, sizeof(*cmd_buffer), 8,
-                               VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+       cmd_buffer = vk_zalloc(&pool->alloc, sizeof(*cmd_buffer), 8,
+                              VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
        if (cmd_buffer == NULL)
                return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 
-       memset(cmd_buffer, 0, sizeof(*cmd_buffer));
        cmd_buffer->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
        cmd_buffer->device = device;
        cmd_buffer->pool = pool;
index aa0511fd8d5308ddc8b38d7fd8ddc83318844c38..929082182c24290e09359e79218017b5e1a213b8 100644 (file)
@@ -372,13 +372,11 @@ VkResult radv_CreateInstance(
                        return vk_error(VK_ERROR_EXTENSION_NOT_PRESENT);
        }
 
-       instance = vk_alloc2(&default_alloc, pAllocator, sizeof(*instance), 8,
-                              VK_SYSTEM_ALLOCATION_SCOPE_INSTANCE);
+       instance = vk_zalloc2(&default_alloc, pAllocator, sizeof(*instance), 8,
+                             VK_SYSTEM_ALLOCATION_SCOPE_INSTANCE);
        if (!instance)
                return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 
-       memset(instance, 0, sizeof(*instance));
-
        instance->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
 
        if (pAllocator)
@@ -995,14 +993,12 @@ VkResult radv_CreateDevice(
                }
        }
 
-       device = vk_alloc2(&physical_device->instance->alloc, pAllocator,
-                            sizeof(*device), 8,
-                            VK_SYSTEM_ALLOCATION_SCOPE_DEVICE);
+       device = vk_zalloc2(&physical_device->instance->alloc, pAllocator,
+                           sizeof(*device), 8,
+                           VK_SYSTEM_ALLOCATION_SCOPE_DEVICE);
        if (!device)
                return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 
-       memset(device, 0, sizeof(*device));
-
        device->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
        device->instance = physical_device->instance;
        device->physical_device = physical_device;
index 0564454c776877b6ea218fa2900ba23f930a52e7..163d35d76bdcc7bf09fd495294ed1a4b771b58bf 100644 (file)
@@ -863,12 +863,11 @@ radv_image_create(VkDevice _device,
        radv_assert(pCreateInfo->extent.height > 0);
        radv_assert(pCreateInfo->extent.depth > 0);
 
-       image = vk_alloc2(&device->alloc, alloc, sizeof(*image), 8,
-                           VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+       image = vk_zalloc2(&device->alloc, alloc, sizeof(*image), 8,
+                          VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
        if (!image)
                return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 
-       memset(image, 0, sizeof(*image));
        image->type = pCreateInfo->imageType;
        image->info.width = pCreateInfo->extent.width;
        image->info.height = pCreateInfo->extent.height;
index 954bc2cd02a52f353de15e0342393bfb9d2bfd1d..f006dc98c05f7cd659760c3bde6beccb0bc8a13e 100644 (file)
@@ -2312,12 +2312,11 @@ radv_graphics_pipeline_create(
        struct radv_pipeline *pipeline;
        VkResult result;
 
-       pipeline = vk_alloc2(&device->alloc, pAllocator, sizeof(*pipeline), 8,
-                              VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+       pipeline = vk_zalloc2(&device->alloc, pAllocator, sizeof(*pipeline), 8,
+                             VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
        if (pipeline == NULL)
                return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 
-       memset(pipeline, 0, sizeof(*pipeline));
        result = radv_pipeline_init(pipeline, device, cache,
                                    pCreateInfo, extra, pAllocator);
        if (result != VK_SUCCESS) {
@@ -2369,12 +2368,11 @@ static VkResult radv_compute_pipeline_create(
        struct radv_pipeline *pipeline;
        VkResult result;
 
-       pipeline = vk_alloc2(&device->alloc, pAllocator, sizeof(*pipeline), 8,
-                              VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
+       pipeline = vk_zalloc2(&device->alloc, pAllocator, sizeof(*pipeline), 8,
+                             VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
        if (pipeline == NULL)
                return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 
-       memset(pipeline, 0, sizeof(*pipeline));
        pipeline->device = device;
        pipeline->layout = radv_pipeline_layout_from_handle(pCreateInfo->layout);