i965: Delete "fast color clear unsupported" performance warning.
authorKenneth Graunke <kenneth@whitecape.org>
Thu, 13 Mar 2014 09:28:14 +0000 (02:28 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Tue, 8 Apr 2014 20:09:46 +0000 (13:09 -0700)
Applications frequently clear to colors other than 0.0 or 1.0, which
prevents us from doing fast color clears.  In that case, we issue this
performance warning on basically every glClear call, resulting in so
much spam that it's nearly impossible to see any other messages.

Plus, I don't think it's useful.  We aren't suggesting a better way to
do what the application developers want---we're just telling them it
would be faster to do something they don't want.

Driver developers have no control over the clear color, so this message
is totally useless to them.

A better alternative to get this sort of information is to use
INTEL_DEBUG=blorp, which tells you whether color clears were fast,
simd16 repdata, or slow.

v2: Rebase on has_color_component changes.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp

index d16da97c3c0d363b2e443816f00ddfb2a087f634..d8aa53c854cf53558fa7aac10dc47773e4afdd94 100644 (file)
@@ -155,8 +155,6 @@ is_color_fast_clear_compatible(struct brw_context *brw,
    for (int i = 0; i < 4; i++) {
       if (color->f[i] != 0.0 && color->f[i] != 1.0 &&
           _mesa_format_has_color_component(format, i)) {
-         perf_debug("Clear color unsupported by fast color clear.  "
-                    "Falling back to slow clear.\n");
          return false;
       }
    }