panfrost: Fix OOB array access compiler warning.
authorEric Anholt <eric@anholt.net>
Tue, 25 Aug 2020 17:20:44 +0000 (10:20 -0700)
committerMarge Bot <eric+marge@anholt.net>
Fri, 28 Aug 2020 22:45:08 +0000 (22:45 +0000)
-1 is used to select "choose the dest type", but we were dereffing src[-1]
anyway and the compiler is not a fan.

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6462>

src/panfrost/bifrost/bir.c

index 3ca57f66f0efde5a939f8049eea96e633f000520..61a5ffc26471c662d515e71f1166d1501d4c1bf5 100644 (file)
@@ -106,7 +106,7 @@ bi_get_component_count(bi_instruction *ins, signed src)
                 return (src <= 0) ? ins->vector_channels : 1;
         } else {
                 unsigned dest_bytes = nir_alu_type_get_type_size(ins->dest_type);
-                unsigned src_bytes = nir_alu_type_get_type_size(ins->src_types[src]);
+                unsigned src_bytes = nir_alu_type_get_type_size(ins->src_types[MAX2(src, 0)]);
 
                 /* If there's either f32 on either end, it's only a single
                  * component, etc. */