package/sysdig: reorder select/depends
authorRomain Naour <romain.naour@gmail.com>
Fri, 1 Jan 2016 20:02:21 +0000 (21:02 +0100)
committerPeter Korsgaard <peter@korsgaard.com>
Fri, 1 Jan 2016 21:00:51 +0000 (22:00 +0100)
>From [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to
understand when depends come first, followed by the selects."

Also, the Config.in exemple in the manual suggest to use this coding
style [2].

[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
package/sysdig/Config.in

index dc71d5f0c55672608df3d485dec1e03774ae7f93..151e75d5f3a91642b3fb538f77a87d98bf481a5f 100644 (file)
@@ -1,12 +1,12 @@
 config BR2_PACKAGE_SYSDIG
        bool "sysdig"
-       select BR2_PACKAGE_ZLIB
-       select BR2_PACKAGE_LUAJIT
-       select BR2_PACKAGE_JSONCPP
        depends on BR2_LINUX_KERNEL
        depends on BR2_INSTALL_LIBSTDCPP # libjson
        depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
        depends on !BR2_STATIC_LIBS # luajit
+       select BR2_PACKAGE_ZLIB
+       select BR2_PACKAGE_LUAJIT
+       select BR2_PACKAGE_JSONCPP
        help
          Sysdig is open source, system-level exploration:
          capture system state and activity from a running Linux instance,