Remove FIXMEs from tui-layout.c

An earlier patch added a couple of FIXME comments to tui-layout.c.
This removes them.  This is possible due to the previous patch that
changed how boxing works in the TUI -- now, no special case for the
command window is needed in box_win.

gdb/ChangeLog
2019-08-15  Tom Tromey  <tom@tromey.com>

	* tui/tui-layout.c (show_source_disasm_command)
	(show_source_or_disasm_and_command): Use make_visible method, not
	tui_make_window.
	* tui/tui-command.h (struct tui_cmd_window) <make_visible>:
	Remove.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 77f4ca07638952b19e3214595c7fd1a4cf604f63..49e01cee373f5ef60bee85dbb4aaf9a8e1dfe284 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2019-08-15  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-layout.c (show_source_disasm_command)
+       (show_source_or_disasm_and_command): Use make_visible method, not
+       tui_make_window.
+       * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
+       Remove.
+
 2019-08-15  Tom Tromey  <tom@tromey.com>
 
        * tui/tui-wingeneral.h (tui_make_window): Update.

diff --git a/gdb/tui/tui-command.h b/gdb/tui/tui-command.h
index 14d775008823db22c9a6d195e721000919b1c29c..1892956fe774e1abc5d6f512b6f0af40cfdac580 100644 (file)
--- a/gdb/tui/tui-command.h
+++ b/gdb/tui/tui-command.h
@@ -35,10 +35,6 @@ struct tui_cmd_window : public tui_win_info
 
   DISABLE_COPY_AND_ASSIGN (tui_cmd_window);
 
-  void make_visible (bool visible) override
-  {
-  }
-
   int max_height () const override;
 
   void refresh_window () override

diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c
index 69b929d37b28000c0cf1ec73dce6911735e4ad3d..c2abcf4429d2f80aae06f995e5b2f10bcb664d2c 100644 (file)
--- a/gdb/tui/tui-layout.c
+++ b/gdb/tui/tui-layout.c
@@ -544,9 +544,7 @@ show_source_disasm_command (void)
                      tui_term_width (),
                      0,
                      tui_term_height () - cmd_height);
-  /* FIXME tui_cmd_window won't recreate the handle on
-     make_visible, so we need this instead.  */
-  tui_make_window (TUI_CMD_WIN);
+  TUI_CMD_WIN->make_visible (true);
   current_layout = SRC_DISASSEM_COMMAND;
 }
 
@@ -672,8 +670,6 @@ show_source_or_disasm_and_command (enum tui_layout_type layout_type)
                      tui_term_width (),
                      0,
                      src_height);
-  /* FIXME tui_cmd_window won't recreate the handle on
-     make_visible, so we need this instead.  */
-  tui_make_window (TUI_CMD_WIN);
+  TUI_CMD_WIN->make_visible (true);
   current_layout = layout_type;
 }