re PR c/18239 (ICE in get_parm_info with werid attribute)

	PR c/18239
	* c-decl.c (get_parm_info): Allow FUNCTION_DECLs to appear amongst
	parameter declarations.

testsuite:
	* gcc.dg/parm-impl-decl-1.c, gcc.dg/parm-impl-decl-2.c: New tests.

From-SVN: r89956

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 84ca2043451ef52b84fb1f5c3209bb2fc6e3587e..eacc39352c7687024c9e8dc9672058ae53514374 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2004-11-01  Joseph S. Myers  <joseph@codesourcery.com>
+
+       PR c/18239
+       * c-decl.c (get_parm_info): Allow FUNCTION_DECLs to appear amongst
+       parameter declarations.
+
 2004-11-01  Andreas Krebbel  <krebbel1@de.ibm.com>
 
        * config/s390/s390.c (regclass_map): Put reg 33 (cc) to CC_REGS group.

diff --git a/gcc/c-decl.c b/gcc/c-decl.c
index 839b5f3b2ab8f3ff5635d5fdf0b9c784d6e8db76..ba4249ac37c2befd656837d1f3a8c537a398fdd3 100644 (file)
--- a/gcc/c-decl.c
+++ b/gcc/c-decl.c
@@ -4855,10 +4855,13 @@ get_parm_info (bool ellipsis)
 
        case CONST_DECL:
        case TYPE_DECL:
+       case FUNCTION_DECL:
          /* CONST_DECLs appear here when we have an embedded enum,
             and TYPE_DECLs appear here when we have an embedded struct
             or union.  No warnings for this - we already warned about the
-            type itself.  */
+            type itself.  FUNCTION_DECLs appear when there is an implicit
+            function declaration in the parameter list.  */
+
          TREE_CHAIN (decl) = others;
          others = decl;
          /* fall through */
@@ -4875,7 +4878,6 @@ get_parm_info (bool ellipsis)
 
          /* Other things that might be encountered.  */
        case LABEL_DECL:
-       case FUNCTION_DECL:
        case VAR_DECL:
        default:
          gcc_unreachable ();

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 3b08af5d0471bbdf1b46d583ffea018733e22065..b4746bcc691b789900944ea945805bd16ff0ef8f 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2004-11-01  Joseph S. Myers  <joseph@codesourcery.com>
+
+       PR c/18239
+       * gcc.dg/parm-impl-decl-1.c, gcc.dg/parm-impl-decl-2.c: New tests.
+
 2004-11-01  Nathan Sidwell  <nathan@codesourcery.com>
 
        PR c++/18064

diff --git a/gcc/testsuite/gcc.dg/parm-impl-decl-1.c b/gcc/testsuite/gcc.dg/parm-impl-decl-1.c
new file mode 100644 (file)
index 0000000..1e45d3b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/parm-impl-decl-1.c
@@ -0,0 +1,33 @@
+/* Test implicit function declarations and other odd declarations in
+   function prototypes.  Bug 18239.  */
+/* Origin: Joseph Myers <joseph@codesourcery.com> */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+/* Implicit function declaration in attribute in definition (testcase
+   from bug).  */
+int
+foo (int __attribute__ ((__mode__ (vector_size(8)))) i) /* { dg-warning "warning: '__mode__' attribute ignored" } */
+{
+  return (long long) i;
+}
+
+/* Various other cases.  */
+
+int f (int [sizeof(g())]);
+int f1 (int [sizeof(g1())]);
+
+int g () { return 1; }
+
+int
+h (int (*p)[sizeof(i())])
+{
+  int g2 (), g3 ();
+  return (*p)[0] + g3() + g2();
+}
+
+int i () { return 2; }
+
+int f2 (int [sizeof(g2())]);
+int f3 (int [sizeof(g3())]);
+int g3 () { return 4; }

diff --git a/gcc/testsuite/gcc.dg/parm-impl-decl-2.c b/gcc/testsuite/gcc.dg/parm-impl-decl-2.c
new file mode 100644 (file)
index 0000000..1f46300
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/parm-impl-decl-2.c
@@ -0,0 +1,7 @@
+/* Test implicit function declarations and other odd declarations in
+   function prototypes.  Make sure that LABEL_DECLs don't occur.  */
+/* Origin: Joseph Myers <joseph@codesourcery.com> */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+int k (int [sizeof &&z]); /* { dg-error "error: label 'z' referenced outside of any function" } */