glsl: Apply the transformation "(a || a) -> a" in opt_algebraic.
authorEric Anholt <eric@anholt.net>
Thu, 31 Oct 2013 07:10:32 +0000 (00:10 -0700)
committerEric Anholt <eric@anholt.net>
Fri, 15 Nov 2013 19:33:07 +0000 (11:33 -0800)
total instructions in shared programs: 1732385 -> 1732373 (-0.00%)
instructions in affected programs:     416 -> 404 (-2.88%)
GAINED:                                0
LOST:                                  0

(That's 4 already-short fragment shaders in dota2)

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
src/glsl/opt_algebraic.cpp

index a07e153ae9234499e53db2d469b99aea2d4c4ac5..3da27e5d61c389cfe18423708e285faf8b503e66 100644 (file)
@@ -388,7 +388,6 @@ ir_algebraic_visitor::handle_expression(ir_expression *ir)
       break;
 
    case ir_binop_logic_or:
-      /* FINISHME: Also simplify (a || a) to (a). */
       if (is_vec_zero(op_const[0])) {
         return ir->operands[1];
       } else if (is_vec_zero(op_const[1])) {
@@ -407,6 +406,9 @@ ir_algebraic_visitor::handle_expression(ir_expression *ir)
           */
          return logic_not(logic_and(op_expr[0]->operands[0],
                                     op_expr[1]->operands[0]));
+      } else if (ir->operands[0]->equals(ir->operands[1])) {
+         /* (a || a) == a */
+         return ir->operands[0];
       }
       break;