[gdb/testsuite] Fix tcl ERROR in gdb_load_no_complaints

In commit cf2b2075299 "[gdb/symtab] Fix element type modification in
read_array_type" I factored out new proc with_complaints out of proc
gdb_load_no_complaints, but when fixing a rebase conflict pre-commit I made a
mistake in gdb_load_no_complaints that is now causing:
...
ERROR: tcl error sourcing dw2-ranges-psym.exp.
ERROR: can't read "save": no such variable
    while executing
"gdb_test_no_output "set complaints $save" """
    (procedure "gdb_load_no_complaints" line 14)
    invoked from within
"gdb_load_no_complaints $binfile"
...

Fix this by removing the offending line.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2021-02-10  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (gdb_load_no_complaints): Remove unnecessary
	"Restore saved setting of complaints".

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 714c91f30ba8a843656e95f1c37f350c610dce49..881f111b5d5cd44d3829bc1ee26f52de1141e0af 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2021-02-10  Tom de Vries  <tdevries@suse.de>
+
+       * lib/gdb.exp (gdb_load_no_complaints): Remove unnecessary
+       "Restore saved setting of complaints".
+
 2021-02-09  Tom de Vries  <tdevries@suse.de>
 
        PR symtab/27341

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 1406b9171515b1ef6c9f1c51cf9270b3b59b53e1..016c678237cbbfd483cae20a110835fd4eff4707 100644 (file)
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5149,9 +5149,6 @@ proc gdb_load_no_complaints { arg } {
     # Verify that there were no complaints.
     set re "^Reading symbols from \[^\r\n\]*\r\n$gdb_prompt $"
     gdb_assert {[regexp $re $gdb_file_cmd_msg]} "No complaints"
-
-    # Restore saved setting of complaints.
-    gdb_test_no_output "set complaints $save" ""
 }
 
 # gdb_reload -- load a file into the target.  Called before "running",