st/mesa: Treat vertex inputs absent in inputMapping as zero in mesa_to_tgsi
authorDanylo Piliaiev <danylo.piliaiev@globallogic.com>
Thu, 23 Apr 2020 09:41:34 +0000 (12:41 +0300)
committerMarge Bot <eric+marge@anholt.net>
Mon, 27 Apr 2020 09:30:06 +0000 (09:30 +0000)
After updating vertex inputs being read based on optimized NIR, they may go out
of sync with inputs in mesa IR. Which is translated to TGSI and used together
with NIR if draw doesn't have llvm.

It's much easier to treat such inputs as zero because there is no pass to
entirely get rid of them and they don't contribute to shader's output.

Fixes: d684fb37bfbc47d098158cb03c0672119a4469fe
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2815
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4705>

src/mesa/state_tracker/st_mesa_to_tgsi.c

index 1f5a3cd077e5f4a485d2472b99bcfc7a2d866aad..6fe8f851757a34f12095bf8099a912bdc90fed5b 100644 (file)
@@ -141,8 +141,12 @@ src_register(struct st_translate *t,
          return t->constants[index];
 
    case PROGRAM_INPUT:
-      assert(t->inputMapping[index] < ARRAY_SIZE(t->inputs));
-      return t->inputs[t->inputMapping[index]];
+      if (t->inputMapping[index] < ARRAY_SIZE(t->inputs))
+         return t->inputs[t->inputMapping[index]];
+      else {
+         assert(t->procType == PIPE_SHADER_VERTEX);
+         return ureg_DECL_constant(t->ureg, 0);
+      }
 
    case PROGRAM_OUTPUT:
       assert(t->outputMapping[index] < ARRAY_SIZE(t->outputs));