mklib: replace if/expr with case
authorTormod Volden <debian.tormod@gmail.com>
Thu, 30 Apr 2009 22:55:54 +0000 (16:55 -0600)
committerBrian Paul <brianp@vmware.com>
Thu, 30 Apr 2009 22:55:54 +0000 (16:55 -0600)
Saves forking an expr for every object.

bin/mklib

index db3bc8325f72956cbbe7947a56e2b97c753b507a..2fd95ba7751b0d0f3a900349613d603cd0dae62b 100755 (executable)
--- a/bin/mklib
+++ b/bin/mklib
@@ -281,18 +281,21 @@ case $ARCH in
            # expand any .a objects into constituent .o files.
            NEWOBJECTS=""
            DELETIA=""
-           for OBJ in ${OBJECTS} ; do
-               if [ `expr match $OBJ '.*\.a'` -gt 0 ] ; then
-                   # extract the .o files from this .a archive
-                   FILES=`ar t $OBJ`
-                   ar x $OBJ
-                   NEWOBJECTS="$NEWOBJECTS $FILES"
-                   # keep track of temporary .o files and delete them below
-                   DELETIA="$DELETIA $FILES"
-               else
-                   # ordinary .o file
-                   NEWOBJECTS="$NEWOBJECTS $OBJ"
-               fi
+           for OBJ in $OBJECTS ; do
+               case $OBJ in
+                   *.a)
+                       # extract the .o files from this .a archive
+                       FILES=`ar t $OBJ`
+                       ar x $OBJ
+                       NEWOBJECTS="$NEWOBJECTS $FILES"
+                       # keep track of temporary .o files and delete them below
+                       DELETIA="$DELETIA $FILES"
+                       ;;
+                   *)
+                       # ordinary .o file
+                       NEWOBJECTS="$NEWOBJECTS $OBJ"
+                       ;;
+               esac
            done
 
             # make lib