re PR middle-end/88448 (gnat.dg/opt66.adb etc. FAIL)

2018-12-11  Richard Biener  <rguenther@suse.de>

	PR middle-end/88448
	PR middle-end/88415
	* gimple.c (gimple_assign_set_rhs_with_ops): Revert previous
	change.
	* tree-complex.c (update_complex_assignment): Properly transfer
	or clean EH info around gimple_assign_set_rhs_with_ops.

From-SVN: r267021

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 9981ddd835943ef2919fe4ffadd9c17b44644548..a40b365be283017302e66ecf4bb5fc2ad77851c0 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,12 @@
+2018-12-11  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/88448
+       PR middle-end/88415
+       * gimple.c (gimple_assign_set_rhs_with_ops): Revert previous
+       change.
+       * tree-complex.c (update_complex_assignment): Properly transfer
+       or clean EH info around gimple_assign_set_rhs_with_ops.
+
 2018-12-11  Richard Earnshaw  <rearnsha@arm.com>
 
        PR target/37369

diff --git a/gcc/gimple.c b/gcc/gimple.c
index 3222a219814c9e46626bc9a3e6d8cdc2e9c4c842..b3548f4f0fde9b96e22389deb9833527c5c469f0 100644 (file)
--- a/gcc/gimple.c
+++ b/gcc/gimple.c
@@ -1752,7 +1752,7 @@ gimple_assign_set_rhs_with_ops (gimple_stmt_iterator *gsi, enum tree_code code,
   if (new_rhs_ops > 2)
     gimple_assign_set_rhs3 (stmt, op3);
   if (stmt != old_stmt)
-    gsi_replace (gsi, stmt, true);
+    gsi_replace (gsi, stmt, false);
 }
 
 

diff --git a/gcc/tree-complex.c b/gcc/tree-complex.c
index 2e104c9defb3f2f0b28d55a35c43c9d10e515ae6..d360a4d4c81f020dae9cc77f44c0886cc07add4f 100644 (file)
--- a/gcc/tree-complex.c
+++ b/gcc/tree-complex.c
@@ -698,12 +698,11 @@ update_complex_components_on_edge (edge e, tree lhs, tree r, tree i)
 static void
 update_complex_assignment (gimple_stmt_iterator *gsi, tree r, tree i)
 {
-  gimple *stmt;
-
+  gimple *old_stmt = gsi_stmt (*gsi);
   gimple_assign_set_rhs_with_ops (gsi, COMPLEX_EXPR, r, i);
-  stmt = gsi_stmt (*gsi);
+  gimple *stmt = gsi_stmt (*gsi);
   update_stmt (stmt);
-  if (maybe_clean_eh_stmt (stmt))
+  if (maybe_clean_or_replace_eh_stmt (old_stmt, stmt))
     bitmap_set_bit (need_eh_cleanup, gimple_bb (stmt)->index);
 
   update_complex_components (gsi, gsi_stmt (*gsi), r, i);