sh.opt (mcbranch-force-delay-slot): New option.

gcc/
	* config/sh/sh.opt (mcbranch-force-delay-slot): New option.
	* doc/invoke.texi (SH options): Document it.
	* config/sh/sh.c (sh_insn_length_adjustment): Check
	TARGET_CBRANCH_FORCE_DELAY_SLOT instead of sh_cpu_attr == CPU_SH2E.

gcc/testsuite/
	* gcc.target/sh/sh.exp (check_effective_target_sh1): New.
	* gcc.target/sh/force-cbranch-delay-slot.c: New.

From-SVN: r220774

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 4011f7449196066646f6db518f16d6eb3e05ba77..5a44fccaf5c2b9ee783152514576d01a8820187f 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2015-02-17  Oleg Endo  <olegendo@gcc.gnu.org>
+
+       * config/sh/sh.opt (mcbranch-force-delay-slot): New option.
+       * doc/invoke.texi (SH options): Document it.
+       * config/sh/sh.c (sh_insn_length_adjustment): Check
+       TARGET_CBRANCH_FORCE_DELAY_SLOT instead of sh_cpu_attr == CPU_SH2E.
+
 2015-02-17  H.J. Lu  <hongjiu.lu@intel.com>
 
        * common.opt (fipa-cp-alignment): New.

diff --git a/gcc/config/sh/sh.c b/gcc/config/sh/sh.c
index 2afd44ebde61fb41d0e4b9b43400f8479ee93bb5..7c9d8e2e0c6626ceafa51fa1e17ca00c0af86d60 100644 (file)
--- a/gcc/config/sh/sh.c
+++ b/gcc/config/sh/sh.c
@@ -10245,11 +10245,10 @@ sh_insn_length_adjustment (rtx_insn *insn)
       && get_attr_needs_delay_slot (insn) == NEEDS_DELAY_SLOT_YES)
     return 2;
 
-  /* SH2e has a bug that prevents the use of annulled branches, so if
-     the delay slot is not filled, we'll have to put a NOP in it.  */
-  if (sh_cpu_attr == CPU_SH2E
-      && JUMP_P (insn)
-      && get_attr_type (insn) == TYPE_CBRANCH
+  /* Increase the insn length of a cbranch without a delay slot insn to
+     force a delay slot which will be stuffed with a nop.  */
+  if (TARGET_CBRANCH_FORCE_DELAY_SLOT && TARGET_SH2
+      && JUMP_P (insn) && get_attr_type (insn) == TYPE_CBRANCH
       && ! sequence_insn_p (insn))
     return 2;
 

diff --git a/gcc/config/sh/sh.opt b/gcc/config/sh/sh.opt
index 6e4ab862a4da41321a7c49ac6d0a6fd3a5baf89e..beb4bc8a0171d63addc843ec5abf31c97e82da58 100644 (file)
--- a/gcc/config/sh/sh.opt
+++ b/gcc/config/sh/sh.opt
@@ -229,7 +229,7 @@ Target RejectNegative Joined UInteger Var(sh_branch_cost) Init(-1)
 Cost to assume for a branch insn
 
 mzdcbranch
-Target Var(TARGET_ZDCBRANCH)
+Target Report Var(TARGET_ZDCBRANCH)
 Assume that zero displacement conditional branches are fast
 
 mcbranchdi
@@ -240,6 +240,10 @@ mcmpeqdi
 Target Undocumented Var(TARGET_CMPEQDI_T) Warn(%qs is deprecated and has no effect)
 Emit cmpeqdi_t pattern even when -mcbranchdi is in effect.
 
+mcbranch-force-delay-slot
+Target Report RejectNegative Var(TARGET_CBRANCH_FORCE_DELAY_SLOT) Init(0)
+Force the usage of delay slots for conditional branches.
+
 mcut2-workaround
 Target RejectNegative Var(TARGET_SH5_CUT2_WORKAROUND)
 Enable SH5 cut2 workaround

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 931002e2b913dad2472eceb0966a253c93947a98..d009cb2c940685e8c5469204ad1dd56f2dd93a70 100644 (file)
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -965,6 +965,7 @@ See RS/6000 and PowerPC Options.
 -maccumulate-outgoing-args -minvalid-symbols @gol
 -matomic-model=@var{atomic-model} @gol
 -mbranch-cost=@var{num} -mzdcbranch -mno-zdcbranch @gol
+-mcbranch-force-delay-slot @gol
 -mfused-madd -mno-fused-madd -mfsca -mno-fsca -mfsrra -mno-fsrra @gol
 -mpretend-cmove -mtas}
 
@@ -20593,6 +20594,13 @@ compiler prefers zero displacement branch code sequences.  This is
 enabled by default when generating code for SH4 and SH4A.  It can be explicitly
 disabled by specifying @option{-mno-zdcbranch}.
 
+@item -mcbranch-force-delay-slot
+@opindex mcbranch-force-delay-slot
+Force the usage of delay slots for conditional branches, which stuffs the delay
+slot with a @code{nop} if a suitable instruction can't be found.  By default
+this option is disabled.  It can be enabled to work around hardware bugs as
+found in the original SH7055.
+
 @item -mfused-madd
 @itemx -mno-fused-madd
 @opindex mfused-madd

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 69c7c50e0eaf3233c709bde1c3dad35e6eff2b8c..866d4d93481cd60d7344fec4c9fba95045c77608 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-02-17  Oleg Endo  <olegendo@gcc.gnu.org>
+
+       * gcc.target/sh/sh.exp (check_effective_target_sh1): New.
+       * gcc.target/sh/force-cbranch-delay-slot.c: New.
+
 2015-02-17  H.J. Lu  <hongjiu.lu@intel.com>
 
        * gcc.dg/ipa/propalign-3.c: New test.

diff --git a/gcc/testsuite/gcc.target/sh/force-cbranch-delay-slot.c b/gcc/testsuite/gcc.target/sh/force-cbranch-delay-slot.c
new file mode 100644 (file)
index 0000000..e828b99
--- /dev/null
+++ b/gcc/testsuite/gcc.target/sh/force-cbranch-delay-slot.c
@@ -0,0 +1,18 @@
+/* Check that the option -mcbranch-force-delay-slot works as expected on
+   targets other than SH1, and that it compiles on SH1 targets without fuzz.  */
+/* { dg-do compile }  */
+/* { dg-options "-O2 -mcbranch-force-delay-slot" }  */
+/* { dg-final { scan-assembler-times "nop" 2 { target { ! sh1 } } } }  */
+
+int g (int, int);
+
+int
+f (int a, int b)
+{
+  /* Expected: 1x bt/s, 1x nop.  */
+  if (a != 5)
+    a = 10;
+
+  /* Expected: 1x jmp, 1x nop.  */
+  return g (a, b);
+}

diff --git a/gcc/testsuite/gcc.target/sh/sh.exp b/gcc/testsuite/gcc.target/sh/sh.exp
index 6f9c97e34e7037a709e2d1794091165aa3b6ce11..f00dbd54cef7c3e6c8cf8ba6afd2fa920f6b7d91 100644 (file)
--- a/gcc/testsuite/gcc.target/sh/sh.exp
+++ b/gcc/testsuite/gcc.target/sh/sh.exp
@@ -33,6 +33,15 @@ proc check_effective_target_sh2a { } {
     } ""]
 }
 
+# Return 1 if target is SH1
+proc check_effective_target_sh1 { } {
+    return [check_no_compiler_messages sh1 object {
+            #ifndef __SH1__
+            #error ""
+            #endif
+    } ""]
+}
+
 # Return 1 if target supports atomic-model=soft-gusa
 proc check_effective_target_atomic_model_soft_gusa_available { } {
     return [check_no_compiler_messages atomic_model_soft_gusa_available object {