infrun.c:handle_inferior_event: Remove some more dead code.
authorPedro Alves <palves@redhat.com>
Mon, 28 Oct 2013 16:39:05 +0000 (16:39 +0000)
committerPedro Alves <palves@redhat.com>
Mon, 28 Oct 2013 16:39:05 +0000 (16:39 +0000)
'ecs' is always memset before being passed to handle_inferior_event.
The stop func is only filled in later in the flow.  And since "Remove
dead sets/clears of ecs->random signal", nothing ever sets
ecs->random_signal before this part is reached either.

(Also tested with some added assertions in place.)

gdb/
2013-10-28  Pedro Alves  <palves@redhat.com>

* infrun.c (clear_stop_func): Delete.
(handle_inferior_event): Don't call clear_stop_func and don't
clear 'ecs->random_signal'.

gdb/ChangeLog
gdb/infrun.c

index b33fc374a0eed2f20f3aaf6bb53b2c858ac81c13..1a0328b5a91cbf23b84d5a2ed9678e752e2d8f33 100644 (file)
@@ -1,3 +1,9 @@
+2013-10-28  Pedro Alves  <palves@redhat.com>
+
+       * infrun.c (clear_stop_func): Delete.
+       (handle_inferior_event): Don't call clear_stop_func and don't
+       clear 'ecs->random_signal'.
+
 2013-10-27  Yao Qi  <yao@codesourcery.com>
 
        * varobj.c (struct varobj_root) <lang>: Rename to 'lang_ops'.
index 4f7068c8996b07ee408048e4954f957a26632393..8b1b668a41c2b873a1ebbe14089be44e3502cbaa 100644 (file)
@@ -3120,17 +3120,6 @@ handle_syscall_event (struct execution_control_state *ecs)
   return 1;
 }
 
-/* Clear the supplied execution_control_state's stop_func_* fields.  */
-
-static void
-clear_stop_func (struct execution_control_state *ecs)
-{
-  ecs->stop_func_filled_in = 0;
-  ecs->stop_func_start = 0;
-  ecs->stop_func_end = 0;
-  ecs->stop_func_name = NULL;
-}
-
 /* Lazily fill in the execution_control_state's stop_func_* fields.  */
 
 static void
@@ -4089,12 +4078,10 @@ Cannot fill $_exitsignal with the correct signal number.\n"));
       return;
     }
 
-  clear_stop_func (ecs);
   ecs->event_thread->stepping_over_breakpoint = 0;
   bpstat_clear (&ecs->event_thread->control.stop_bpstat);
   ecs->event_thread->control.stop_step = 0;
   stop_print_frame = 1;
-  ecs->random_signal = 0;
   stopped_by_random_signal = 0;
 
   /* Hide inlined functions starting here, unless we just performed stepi or