Change tui_source_element::line to be a unique_xmalloc_ptr

This changes tui_source_element::line to be a unique_xmalloc_ptr,
removing some manual memory management.

gdb/ChangeLog
2019-09-20  Tom Tromey  <tom@tromey.com>

	* tui/tui-winsource.h (~tui_source_element): Remove.
	(tui_source_element): Update.
	(struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
	* tui/tui-winsource.c (tui_show_source_line): Update.
	* tui/tui-source.c (tui_source_window::set_contents): Update.
	* tui/tui-disasm.c (tui_disasm_window::set_contents): Update.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bedc073d9c8c92a53e1ea512a0995ec72de22996..3d322877df732ebc30d8b2063f15dcb0ab3789c1 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2019-09-20  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.h (~tui_source_element): Remove.
+       (tui_source_element): Update.
+       (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
+       * tui/tui-winsource.c (tui_show_source_line): Update.
+       * tui/tui-source.c (tui_source_window::set_contents): Update.
+       * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
+
 2019-09-20  Tom Tromey  <tom@tromey.com>
 
        * tui/tui-data.h (tui_clear_source_windows_detail): Don't

diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 1d019ca60c106ad8d4c31bb1c11f54ce05ac28c8..2a331327e77e2e1a7ae1a7eaef3587565b6ee00a 100644 (file)
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -231,11 +231,10 @@ tui_disasm_window::set_contents (struct gdbarch *arch,
       strcpy (line + insn_pos, asm_lines[i].insn);
 
       /* Now copy the line taking the offset into account.  */
-      xfree (src->line);
       if (strlen (line) > offset)
-       src->line = xstrndup (&line[offset], line_width);
+       src->line.reset (xstrndup (&line[offset], line_width));
       else
-       src->line = xstrdup ("");
+       src->line.reset (xstrdup (""));
 
       src->line_or_addr.loa = LOA_ADDRESS;
       src->line_or_addr.u.addr = asm_lines[i].addr;

diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index 906006a4225ab4240a803ad82ee1212c791f459c..c379173018d725748e2eb0954aad70e8d3a8b694 100644 (file)
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -184,9 +184,7 @@ tui_source_window::set_contents (struct gdbarch *arch,
                                 symtab_to_fullname (s)) == 0
                   && cur_line_no == locator->line_no);
 
-             xfree (content[cur_line].line);
-             content[cur_line].line
-               = xstrdup (text.c_str ());
+             content[cur_line].line.reset (xstrdup (text.c_str ()));
 
              cur_line++;
              cur_line_no++;

diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 4520a1ac3fea2f080161b931221e641a7fabe4cd..d5281193c0e7ddb825987bb00e91b9df0379eea4 100644 (file)
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -222,8 +222,7 @@ tui_show_source_line (struct tui_source_window_base *win_info, int lineno)
     tui_set_reverse_mode (win_info->handle, true);
 
   wmove (win_info->handle, lineno, TUI_EXECINFO_SIZE);
-  tui_puts (line->line,
-           win_info->handle);
+  tui_puts (line->line.get (), win_info->handle);
   if (line->is_exec_point)
     tui_set_reverse_mode (win_info->handle, false);
 

diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 445cc7c73572ff1b7a96010d7254728775c885a5..64f0739e5363c094f7a7387a630067895959501d 100644 (file)
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -54,23 +54,17 @@ struct tui_source_element
     line_or_addr.u.line_no = 0;
   }
 
-  ~tui_source_element ()
-  {
-    xfree (line);
-  }
-
   DISABLE_COPY_AND_ASSIGN (tui_source_element);
 
   tui_source_element (tui_source_element &&other)
-    : line (other.line),
+    : line (std::move (other.line)),
       line_or_addr (other.line_or_addr),
       is_exec_point (other.is_exec_point),
       break_mode (other.break_mode)
   {
-    other.line = nullptr;
   }
 
-  char *line = nullptr;
+  gdb::unique_xmalloc_ptr<char> line;
   struct tui_line_or_address line_or_addr;
   bool is_exec_point = false;
   tui_bp_flags break_mode = 0;