write_pieced_value: Include transfer size in byte-wise check

In write_pieced_value, when checking whether the data can be transferred
byte-wise, the current logic verifies the source- and destination offsets
to be byte-aligned, but not the transfer size.  This is fixed.

gdb/ChangeLog:

	* dwarf2loc.c (write_pieced_value): Include transfer size in
	byte-wise check.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0845c61be94c75618117d2c61ffa599b1720b4ee..ee4c9d8b217af00e1cc54b4c87761c5ac0fc8ca1 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-06-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
+
+       * dwarf2loc.c (write_pieced_value): Include transfer size in
+       byte-wise check.
+
 2017-06-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
 
        * dwarf2loc.c (write_pieced_value): Fix copy/paste error in the

diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 1122c8a249317bef23dfc155c3d01291cf7c8f58..2849dadb77269733a6884b96e93bd41c0c969796 100644 (file)
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -1986,7 +1986,10 @@ write_pieced_value (struct value *to, struct value *from)
       this_size = (this_size_bits + dest_offset_bits % 8 + 7) / 8;
       source_offset = source_offset_bits / 8;
       dest_offset = dest_offset_bits / 8;
-      if (dest_offset_bits % 8 == 0 && source_offset_bits % 8 == 0)
+
+      /* Check whether the data can be transferred byte-wise.  */
+      if (dest_offset_bits % 8 == 0 && source_offset_bits % 8 == 0
+         && this_size_bits % 8 == 0)
        {
          source_buffer = contents + source_offset;
          need_bitwise = 0;