Disable gdbserver on host != target configurations
authorMaciej W. Rozycki <macro@wdc.com>
Wed, 12 Feb 2020 13:50:30 +0000 (13:50 +0000)
committerPedro Alves <palves@redhat.com>
Wed, 12 Feb 2020 13:50:30 +0000 (13:50 +0000)
Correct fallout from commit 919adfe84092 ("Move gdbserver to top level")
and revert to not building `gdbserver' in a cross-configuration, that is
where host != target, matching the documented behaviour.  We have no way
to support non-native `gdbserver', and native `gdbserver' is usually of
no use with cross-GDB of the chosen host.

gdbserver/ChangeLog:
2020-02-12  Maciej W. Rozycki <macro@wdc.com>
    Pedro Alves  <palves@redhat.com>

Skip building gdbserver in a cross-configuration.
* configure.srv: Set $gdbserver_host depending on whether $target
is $host.  Use $gdbserver_host instead of $host.

gdbserver/ChangeLog
gdbserver/configure.srv

index 09707067730202b04329bb76bf743b520ce784c6..709ef23674c4f85587531cb4b2afa79598737650 100644 (file)
@@ -1,3 +1,10 @@
+2020-02-12  Maciej W. Rozycki <macro@wdc.com>
+           Pedro Alves  <palves@redhat.com>
+
+       Skip building gdbserver in a cross-configuration.
+       * configure.srv: Set $gdbserver_host depending on whether $target
+       is $host.  Use $gdbserver_host instead of $host.
+
 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 
        * configure: Re-generate.
index 2e83cbdc07fec2595007d6b5d54808433c6e5315..375ac0aeb2a5811247f384a8f5cbcf227e1579eb 100644 (file)
@@ -33,9 +33,16 @@ ipa_ppc_linux_regobj="powerpc-32l-ipa.o powerpc-altivec32l-ipa.o powerpc-vsx32l-
 # these files over and over again.
 srv_linux_obj="linux-low.o nat/linux-osdata.o nat/linux-procfs.o nat/linux-ptrace.o nat/linux-waitpid.o nat/linux-personality.o nat/linux-namespaces.o fork-child.o nat/fork-inferior.o"
 
-# Input is taken from the "${host}" variable.
+# Input is taken from the "${host}" and "${target}" variables.
 
-case "${host}" in
+# GDBserver can only debug native programs.
+if test "${target}" = "${host}"; then
+    gdbserver_host=${host}
+else
+    gdbserver_host=
+fi
+
+case "${gdbserver_host}" in
   aarch64*-*-linux*)   srv_tgtobj="linux-aarch64-low.o"
                        srv_tgtobj="$srv_tgtobj nat/aarch64-linux-hw-point.o"
                        srv_tgtobj="$srv_tgtobj linux-aarch32-low.o"