Make obstack_strdup inline

This changes obstack_strdup to be an inline function.  This seems
better to me, considering how small it is; but also it follows what
the code did before the previous patch.

gdb/ChangeLog
2019-08-06  Tom Tromey  <tom@tromey.com>

	* gdb_obstack.h (obstack_strdup): Define.
	* gdb_obstack.c (obstack_strdup): Don't define.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3974808c0782d16c1b3a0c855d15ba03e0c5c000..29ffa1e96238837235109f41af4b926d894a0a46 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-06  Tom Tromey  <tom@tromey.com>
+
+       * gdb_obstack.h (obstack_strdup): Define.
+       * gdb_obstack.c (obstack_strdup): Don't define.
+
 2019-08-06  Tom Tromey  <tom@tromey.com>
 
        * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use

diff --git a/gdb/gdb_obstack.c b/gdb/gdb_obstack.c
index 0bf4abb82f6041a2d91333f15932af90b92f6074..01257120d076c51ff4459e6c53896c829eab2d23 100644 (file)
--- a/gdb/gdb_obstack.c
+++ b/gdb/gdb_obstack.c
@@ -45,13 +45,3 @@ obconcat (struct obstack *obstackp, ...)
 
   return (char *) obstack_finish (obstackp);
 }
-
-/* See gdb_obstack.h.  */
-
-char *
-obstack_strdup (struct obstack *obstackp, const char *string)
-{
-  char *obstring = (char *) obstack_alloc (obstackp, strlen (string) + 1);
-  strcpy (obstring, string);
-  return obstring;
-}

diff --git a/gdb/gdb_obstack.h b/gdb/gdb_obstack.h
index 143fcf7179f5308b3d9273591ecdfffc92da96a3..829e2f959c41475d245fb46d1c911a2fae94a431 100644 (file)
--- a/gdb/gdb_obstack.h
+++ b/gdb/gdb_obstack.h
@@ -89,7 +89,11 @@ extern char *obconcat (struct obstack *obstackp, ...) ATTRIBUTE_SENTINEL;
 /* Duplicate STRING, returning an equivalent string that's allocated on the
    obstack OBSTACKP.  */
 
-extern char *obstack_strdup (struct obstack *obstackp, const char *string);
+static inline char *
+obstack_strdup (struct obstack *obstackp, const char *string)
+{
+  return (char *) obstack_copy0 (obstackp, string, strlen (string));
+}
 
 /* An obstack that frees itself on scope exit.  */
 struct auto_obstack : obstack