Share target_wait prototype between GDB and gdbserver

This commit moves the target_wait prototype from the GDB-specific
target.h header to the common target/target.h header.  Then, it
creates a compatible implementation of target_wait on gdbserver using
the_target->wait, and adjusts the (only) caller (mywait function).

Pretty straightforward, no regressions introduced.

gdb/gdbserver/ChangeLog:
2016-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>

	* target.c (mywait): Call target_wait instead of
	the_target->wait.
	(target_wait): New function.

gdb/ChangeLog:
2016-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>

	* target.c (target_wait): Mention that the function's prototype
	can be found at target/target.h.
	* target.h (target_wait): Move prototype from here...
	* target/target.h (target_wait): ... to here.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 60b595079a3a776775cc66c3a972641c42e3fd95..08509fbdc1c4f2480fd29600addc1703fbb5d665 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2016-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+       * target.c (target_wait): Mention that the function's prototype
+       can be found at target/target.h.
+       * target.h (target_wait): Move prototype from here...
+       * target/target.h (target_wait): ... to here.
+
 2016-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 
        * fork-child.c (startup_inferior): Replace calls to target_resume

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 921a5d4536c6193b18f80e3a3e2830993f365832..97d8ca59a41dd569962c0085fa8365520a127001 100644 (file)
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,9 @@
+2016-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+       * target.c (mywait): Call target_wait instead of
+       the_target->wait.
+       (target_wait): New function.
+
 2016-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 
        * server.c (start_inferior): New variable 'ptid'.  Replace calls

diff --git a/gdb/gdbserver/target.c b/gdb/gdbserver/target.c
index 8435dc2b260fc9648c64ac16debba09af0c71224..053629ca7d7b792ffc9e3ebbf041234ab1cd1626 100644 (file)
--- a/gdb/gdbserver/target.c
+++ b/gdb/gdbserver/target.c
@@ -211,7 +211,7 @@ mywait (ptid_t ptid, struct target_waitstatus *ourstatus, int options,
   if (connected_wait)
     server_waiting = 1;
 
-  ret = (*the_target->wait) (ptid, ourstatus, options);
+  ret = target_wait (ptid, ourstatus, options);
 
   /* We don't expose _LOADED events to gdbserver core.  See the
      `dlls_changed' global.  */
@@ -258,6 +258,14 @@ target_stop_and_wait (ptid_t ptid)
 
 /* See target/target.h.  */
 
+ptid_t
+target_wait (ptid_t ptid, struct target_waitstatus *status, int options)
+{
+  return (*the_target->wait) (ptid, status, options);
+}
+
+/* See target/target.h.  */
+
 void
 target_continue_no_signal (ptid_t ptid)
 {

diff --git a/gdb/target.c b/gdb/target.c
index 87c968146817833091201816c3fe121f0f50421f..bca25bd9dba4eef43057ba11af78d4f46de2727a 100644 (file)
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -2283,6 +2283,8 @@ target_disconnect (const char *args, int from_tty)
   current_target.to_disconnect (&current_target, args, from_tty);
 }
 
+/* See target/target.h.  */
+
 ptid_t
 target_wait (ptid_t ptid, struct target_waitstatus *status, int options)
 {

diff --git a/gdb/target.h b/gdb/target.h
index 9506e04ec9bf5760c8d4765da84fcf66c35980f6..493a6139db37c69da44e2c89d94c224df6a2747b 100644 (file)
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1341,17 +1341,7 @@ extern void target_disconnect (const char *, int);
 
 extern void target_resume (ptid_t ptid, int step, enum gdb_signal signal);
 
-/* Wait for process pid to do something.  PTID = -1 to wait for any
-   pid to do something.  Return pid of child, or -1 in case of error;
-   store status through argument pointer STATUS.  Note that it is
-   _NOT_ OK to throw_exception() out of target_wait() without popping
-   the debugging target from the stack; GDB isn't prepared to get back
-   to the prompt with a debugging target but without the frame cache,
-   stop_pc, etc., set up.  OPTIONS is a bitwise OR of TARGET_W*
-   options.  */
-
-extern ptid_t target_wait (ptid_t ptid, struct target_waitstatus *status,
-                          int options);
+/* For target_read_memory see target/target.h.  */
 
 /* The default target_ops::to_wait implementation.  */
 

diff --git a/gdb/target/target.h b/gdb/target/target.h
index 64ef782d354acb4b5b82430a678b12b378461457..972bcb7d2ddbabc3302d0cdd97138bebdbffa179 100644 (file)
--- a/gdb/target/target.h
+++ b/gdb/target/target.h
@@ -74,4 +74,16 @@ extern void target_continue_no_signal (ptid_t ptid);
 
 extern void target_continue (ptid_t ptid, enum gdb_signal signal);
 
+/* Wait for process pid to do something.  PTID = -1 to wait for any
+   pid to do something.  Return pid of child, or -1 in case of error;
+   store status through argument pointer STATUS.  Note that it is
+   _NOT_ OK to throw_exception() out of target_wait() without popping
+   the debugging target from the stack; GDB isn't prepared to get back
+   to the prompt with a debugging target but without the frame cache,
+   stop_pc, etc., set up.  OPTIONS is a bitwise OR of TARGET_W*
+   options.  */
+
+extern ptid_t target_wait (ptid_t ptid, struct target_waitstatus *status,
+                          int options);
+
 #endif /* TARGET_COMMON_H */