Add FIXME explaining include problem.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 353eaf9586553c524d562a29a1cf6a725a9a5da9..0e2c5f06cbfe52e57fb978fabb1e4dc962a1b546 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2002-03-01  Andrew Cagney  <ac131313@redhat.com>
+
+       * utils.c: Add FIXME explaining true/false problem.
+
 2002-02-28  Andrew Cagney  <ac131313@redhat.com>
 
        * MAINTAINERS (Past Maintainers): Add J.T. Conklin.

diff --git a/gdb/tui/ChangeLog b/gdb/tui/ChangeLog
index 00a7e1232923c758c99a5b1c320b577bd88bc1c8..2f676a88d1b42432bb5269f151885ca14fe0388e 100644 (file)
--- a/gdb/tui/ChangeLog
+++ b/gdb/tui/ChangeLog
@@ -1,3 +1,28 @@
+2002-03-01  Andrew Cagney  <ac131313@redhat.com>
+
+       * tui-hooks.c: Add FIXME to explain true/false problem.  Update
+       copyright.
+       * tui.c, tuiCommand.c, tuiData.c, tuiDataWin.c: Ditto.
+       * tuiDisassem.c, tuiGeneralWin.c, tuiIO.c, tuiLayout.c: Ditto.
+       * tuiRegs.c, tuiSource.c, tuiSourceWin.c, tuiStack.c: Ditto.
+       * tuiWin.c: Ditto.
+
+       2002-02-08  Daniel Jacobowitz  <drow@mvista.com>
+       * tui-hooks.c: Include <curses.h> before "bfd.h".
+       * tui.c: Likewise.
+       * tuiCommand.c: Likewise.
+       * tuiData.c: Likewise.
+       * tuiDataWin.c: Likewise.
+       * tuiDisassem.c: Likewise.
+       * tuiGeneralWin.c: Likewise.
+       * tuiIO.c: Likewise.
+       * tuiLayout.c: Likewise.
+       * tuiRegs.c: Likewise.
+       * tuiSource.c: Likewise.
+       * tuiSourceWin.c: Likewise.
+       * tuiStack.c: Likewise.
+       * tuiWin.c: Likewise.
+
 2002-02-01  Andrew Cagney  <ac131313@redhat.com>
 
        * tuiWin.c (_initialize_tuiWin): Replace NO_FUNCTION with NULL.

diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c
index 38cfc5721839ed21467667a944fee93b8b0100b0..27556acfd151528264c16022a1870ecc1a1b37fb 100644 (file)
--- a/gdb/tui/tui-hooks.c
+++ b/gdb/tui/tui-hooks.c
@@ -1,5 +1,6 @@
 /* GDB hooks for TUI.
-   Copyright 2001 Free Software Foundation, Inc.
+
+   Copyright 2001, 2002 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -18,7 +19,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H
 #include <ncurses.h>

diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 18d706fe250e720214f79f1a685590a00daf74f0..7912efc8765c6886250c08ee26410b6739869385 100644 (file)
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -1,5 +1,8 @@
 /* General functions for the WDB TUI.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiCommand.c b/gdb/tui/tuiCommand.c
index fd868e25a402eb5ef16888c54640a4fe0080a845..ca3d5318ea9cabcf3d4189ab87fe79c01e522e48 100644 (file)
--- a/gdb/tui/tuiCommand.c
+++ b/gdb/tui/tuiCommand.c
@@ -1,5 +1,8 @@
 /* Specific command window processing.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiData.c b/gdb/tui/tuiData.c
index 256f694e87020971b59fee95d013e112d99bf619..30efba8b11c661c2645388bcfe03988cbc7e0dc2 100644 (file)
--- a/gdb/tui/tuiData.c
+++ b/gdb/tui/tuiData.c
@@ -1,5 +1,8 @@
 /* TUI data manipulation routines.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiDataWin.c b/gdb/tui/tuiDataWin.c
index cb670ed7a26b11dbd153b9fcfdcb89e2d544ff97..e729afc7f72a9e171f55b74287b2dd5e463ee3a9 100644 (file)
--- a/gdb/tui/tuiDataWin.c
+++ b/gdb/tui/tuiDataWin.c
@@ -1,5 +1,8 @@
 /* Data/register window display.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiDisassem.c b/gdb/tui/tuiDisassem.c
index 2cab1be5e84f56e052988a9517894e1685eb26c9..8e59e68d6933fda14bf7ebea7d9d47ae77999eb1 100644 (file)
--- a/gdb/tui/tuiDisassem.c
+++ b/gdb/tui/tuiDisassem.c
@@ -1,5 +1,8 @@
 /* Disassembly display.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiGeneralWin.c b/gdb/tui/tuiGeneralWin.c
index b6d84e46d91157c8f62e4e292c1b0250c2162bb5..b3f8b919a5d972fb3e1186eedf9ef3eda7980e65 100644 (file)
--- a/gdb/tui/tuiGeneralWin.c
+++ b/gdb/tui/tuiGeneralWin.c
@@ -1,5 +1,8 @@
 /* General window behavior.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiIO.c b/gdb/tui/tuiIO.c
index 31e7c23ad2be9cc2a3ba916dac601b72ba6d8071..d664128ebd6e59480d49bb9bd5adc38379679a1f 100644 (file)
--- a/gdb/tui/tuiIO.c
+++ b/gdb/tui/tuiIO.c
@@ -1,5 +1,8 @@
 /* TUI support I/O functions.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiLayout.c b/gdb/tui/tuiLayout.c
index 061317855f33cb99441ebc84df0c9d8b4914b9b8..aa98882d9d38143ee952079272ac4c7390d2f896 100644 (file)
--- a/gdb/tui/tuiLayout.c
+++ b/gdb/tui/tuiLayout.c
@@ -1,5 +1,8 @@
 /* TUI layout window management.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiRegs.c b/gdb/tui/tuiRegs.c
index dc684fd21372a03a7c5a782ec0373ea1f1e25346..d76c67ea8beea370a1758596c91f2d85f9e5ac4f 100644 (file)
--- a/gdb/tui/tuiRegs.c
+++ b/gdb/tui/tuiRegs.c
@@ -1,5 +1,8 @@
 /* TUI display registers in window.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiSource.c b/gdb/tui/tuiSource.c
index 3ad71bcc88bd5699638f05ca36807ba123a00c6c..1552ac79d0d140c727da7d9011a7ab4de0e7a7d4 100644 (file)
--- a/gdb/tui/tuiSource.c
+++ b/gdb/tui/tuiSource.c
@@ -1,5 +1,8 @@
 /* TUI display source window.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiSourceWin.c b/gdb/tui/tuiSourceWin.c
index 3deac193d9749c2995c8c1dc5fd52f5ff47570c8..7563c940de00797357f092f77a63724c4867660b 100644 (file)
--- a/gdb/tui/tuiSourceWin.c
+++ b/gdb/tui/tuiSourceWin.c
@@ -1,5 +1,8 @@
 /* TUI display source/assembly window.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiStack.c b/gdb/tui/tuiStack.c
index 9b664ed8a3e55c0310ab372973527fe0dc86e9f1..43d022928f6e99b34f2caff95e415d1f55729257 100644 (file)
--- a/gdb/tui/tuiStack.c
+++ b/gdb/tui/tuiStack.c
@@ -1,5 +1,8 @@
 /* TUI display locator.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -19,7 +22,14 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/tui/tuiWin.c b/gdb/tui/tuiWin.c
index b5b6d6d076d16291c49180ea16de57f2be26df3e..a33f6613606269338f9f0f27926b6d4b370bb077 100644 (file)
--- a/gdb/tui/tuiWin.c
+++ b/gdb/tui/tuiWin.c
@@ -1,5 +1,8 @@
 /* TUI window generic functions.
-   Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
+
+   Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
+   Inc.
+
    Contributed by Hewlett-Packard Company.
 
    This file is part of GDB.
@@ -24,7 +27,14 @@
 
    Author: Susan B. Macchia  */
 
-/* If we need <curses.h>, we must include it before we get "bfd.h".  */
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 #ifdef HAVE_NCURSES_H       
 #include <ncurses.h>

diff --git a/gdb/utils.c b/gdb/utils.c
index af1a103b92dd05b1987a52a74e47f8edc2c78f9e..be9dc457b17ae9e74aa94cf0c59d38508ed27a77 100644 (file)
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -20,10 +20,16 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
+/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
+   "defs.h" should be included first.  Unfortunatly some systems
+   (currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
+   and they clash with "bfd.h"'s definiton of true/false.  The correct
+   fix is to remove true/false from "bfd.h", however, until that
+   happens, hack around it by including "config.h" and <curses.h>
+   first.  */
+
 #include "config.h"
 
-/* Include before "bfd.h" so that we get stdbool.h in time, if <curses.h>
-   brings it in.  */
 #ifdef HAVE_CURSES_H
 #include <curses.h>
 #endif