re PR rtl-optimization/56732 (ICE in advance_target_bb)
authorGreta Yorsh <greta.yorsh@arm.com>
Thu, 2 May 2013 15:45:10 +0000 (16:45 +0100)
committerGreta Yorsh <gretay@gcc.gnu.org>
Thu, 2 May 2013 15:45:10 +0000 (16:45 +0100)
gcc/ChangeLog

2013-05-02  Greta Yorsh  <Greta.Yorsh@arm.com>

PR target/56732
* config/arm/arm.c (arm_expand_epilogue): Check really_return before
generating simple_return for naked functions.

gcc/testsuite/ChangeLog

2013-05-02  Greta Yorsh  <Greta.Yorsh@arm.com>

PR target/56732
* gcc.target/arm/pr56732-1.c: New test.

From-SVN: r198547

gcc/ChangeLog
gcc/config/arm/arm.c
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.target/arm/pr56732-1.c [new file with mode: 0644]

index 5a3d4666076d6e188043a7bbad05b122381ada76..cd257b12c7563fb29309b25510ba9bbfff2becdd 100644 (file)
@@ -1,3 +1,9 @@
+2013-05-02  Greta Yorsh  <Greta.Yorsh@arm.com>
+
+       PR target/56732
+       * config/arm/arm.c (arm_expand_epilogue): Check really_return before
+       generating simple_return for naked functions.
+
 2013-05-02  Martin Jambor  <mjambor@suse.cz>
 
        PR middle-end/56988
index bc4247358ebad52e4db2c77364fc4f5b4355875e..0b97cf89d18b780827d6dd42fa3baad3985e49a2 100644 (file)
@@ -24114,7 +24114,8 @@ arm_expand_epilogue (bool really_return)
   if (IS_NAKED (func_type)
       || (IS_VOLATILE (func_type) && TARGET_ABORT_NORETURN))
     {
-      emit_jump_insn (simple_return_rtx);
+      if (really_return)
+        emit_jump_insn (simple_return_rtx);
       return;
     }
 
index 1f345ffb700d6644fe863d7faf8ce0064a1051b6..28a1f4336ccc467bd8850b95fba888f0cf9b26b6 100644 (file)
@@ -1,3 +1,8 @@
+2013-05-02  Greta Yorsh  <Greta.Yorsh@arm.com>
+
+       PR target/56732
+       * gcc.target/arm/pr56732-1.c: New test.
+
 2013-05-02  Martin Jambor  <mjambor@suse.cz>
 
        PR middle-end/56988
diff --git a/gcc/testsuite/gcc.target/arm/pr56732-1.c b/gcc/testsuite/gcc.target/arm/pr56732-1.c
new file mode 100644 (file)
index 0000000..ac8b8cf
--- /dev/null
@@ -0,0 +1,20 @@
+/* { dg-do compile } */
+/* { dg-require-effective-target naked_functions } */
+/* { dg-options "-O2 -Wall" } */
+extern void bar();
+
+void __attribute__((__naked__))
+foo(void)
+{
+  bar ();
+}
+
+int __attribute__((naked))
+zoo (int a, int b, int c, int d, int e, int f)
+{
+  bar ();
+  return e;
+}
+/* Verify that __attribute__((naked)) produces a naked function that
+   does not use bx to return. */
+/* { dg-final { scan-assembler-not "\tbx\tlr" } } */