dllwrap, windres and dlltools use mktemp, which should be avoided

	PR 29534
	* dllwrap.c: Replace uses of choose_temp_base() with
	make_temp_file().
	* dlltool.c: Likewise.
	* resrc.c: Likewise.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 04ef77c55307a57a004a239c53adda21d96c4b98..b5711097d50766217224c96fcb6208048f25b58a 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,11 @@
+2022-09-01  Nick Clifton  <nickc@redhat.com>
+
+       PR 29534
+       * dllwrap.c: Replace uses of choose_temp_base() with
+       make_temp_file().
+       * dlltool.c: Likewise.
+       * resrc.c: Likewise.
+
 2022-08-23  Nick Clifton  <nickc@redhat.com>
 
        PR 29489

diff --git a/binutils/dlltool.c b/binutils/dlltool.c
index b4ac842212a90ff7fb7e046ec56bd2d8857c0318..a3c5e0f778ef62a31d899cb967872956b21ebf99 100644 (file)
--- a/binutils/dlltool.c
+++ b/binutils/dlltool.c
@@ -1270,7 +1270,7 @@ run (const char *what, char *args)
   int i;
   const char **argv;
   char *errmsg_fmt = NULL, *errmsg_arg = NULL;
-  char *temp_base = choose_temp_base ();
+  char *temp_base = make_temp_file ("");
 
   inform (_("run: %s %s"), what, args);
 

diff --git a/binutils/dllwrap.c b/binutils/dllwrap.c
index 1be3cec72f1d5c002b8f3215fc4230af5fcf9bad..7c77701f4e95ec0b3be05674365d859a34d66b02 100644 (file)
--- a/binutils/dllwrap.c
+++ b/binutils/dllwrap.c
@@ -351,7 +351,7 @@ run (const char *what, char *args)
   int i;
   const char **argv;
   char *errmsg_fmt = NULL, *errmsg_arg = NULL;
-  char *temp_base = choose_temp_base ();
+  char *temp_base = make_temp_file (NULL);
   int in_quote;
   char sep;
 
@@ -818,7 +818,7 @@ main (int argc, char **argv)
 
   if (! def_file_seen)
     {
-      char *fileprefix = choose_temp_base ();
+      char *fileprefix = make_temp_file (NULL);
 
       def_file_name = (char *) xmalloc (strlen (fileprefix) + 5);
       sprintf (def_file_name, "%s.def",
@@ -1031,7 +1031,7 @@ Creating one, but that may not be what you want"));
 
   if (! base_file_name)
     {
-      char *fileprefix = choose_temp_base ();
+      char *fileprefix = make_temp_file (NULL);
       base_file_name = (char *) xmalloc (strlen (fileprefix) + 6);
       sprintf (base_file_name, "%s.base",
               (dontdeltemps) ? mybasename (fileprefix) : fileprefix);

diff --git a/binutils/resrc.c b/binutils/resrc.c
index fff77f4f28acf79f29bb740d2a4d1a779127f467..2cf168e0f58df91d462f7673292326f56ec37e05 100644 (file)
--- a/binutils/resrc.c
+++ b/binutils/resrc.c
@@ -202,7 +202,7 @@ run_cmd (char *cmd, const char *redir)
   int i;
   const char **argv;
   char *errmsg_fmt = NULL, *errmsg_arg = NULL;
-  char *temp_base = choose_temp_base ();
+  char *temp_base = make_temp_file (NULL);
   int in_quote;
   char sep;
   int redir_handle = -1;
@@ -316,7 +316,7 @@ open_input_stream (char *cmd)
     {
       char *fileprefix;
 
-      fileprefix = choose_temp_base ();
+      fileprefix = make_temp_file (NULL);
       cpp_temp_file = (char *) xmalloc (strlen (fileprefix) + 5);
       sprintf (cpp_temp_file, "%s.irc", fileprefix);
       free (fileprefix);