Prevent a run time segmentation fault when stripping a corrupt binary.

	PR 20096
	* objcopy.c (copy_relocations_in_section): Also check for the
	symbol pointed to by sym_ptr_ptr being NULL.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index c4bb34eb6b63ea038f4390b876c2856e819ad9ef..64b409e26dd97fb3d5c3bed8f609240c2a1ac418 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2016-05-18  Nick Clifton  <nickc@redhat.com>
+
+       PR 20096
+       * objcopy.c (copy_relocations_in_section): Also check for the
+       symbol pointed to by sym_ptr_ptr being NULL.
+
 2016-05-18  Maciej W. Rozycki  <macro@imgtec.com>
 
        * testsuite/binutils-all/mips/mixed-mips16-micromips.d: New test.

diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index 198ba3a2071e1670f33c9888d30db1342fd54e01..0b218995a969bea9880f0b990f31c22935614c3c 100644 (file)
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -3250,7 +3250,9 @@ copy_relocations_in_section (bfd *ibfd, sec_ptr isection, void *obfdarg)
          for (i = 0; i < relcount; i++)
            {
              /* PR 17512: file: 9e907e0c.  */
-             if (relpp[i]->sym_ptr_ptr)
+             if (relpp[i]->sym_ptr_ptr
+                 /* PR 20096 */
+                 && * relpp[i]->sym_ptr_ptr)
                if (is_specified_symbol (bfd_asymbol_name (*relpp[i]->sym_ptr_ptr),
                                         keep_specific_htab))
                  temp_relpp [temp_relcount++] = relpp [i];