r600g, radeonsi: fix primitives-generated query with disabled streamout

Buffers are disabled by VGT_STRMOUT_BUFFER_CONFIG, but the query only works
if VGT_STRMOUT_CONFIG.STREAMOUT_0_EN is enabled.

This moves VGT_STRMOUT_CONFIG to its own state. The register is set to 1
if either streamout or the primitives-generated query is enabled.

However, the primitives-emitted query is also incremented, so it's disabled
by setting VGT_STRMOUT_BUFFER_SIZE to 0 when there is no buffer bound.

This fixes piglit:
  ARB_transform_feedback2/counting with pause
  EXT_transform_feedback/primgen-query transform-feedback-disabled

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>

diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c
index dca7c58d415eae0779eb1e1717aa4d40240a7fba..18c2ee59b87496d524cc578da8fffb0f600b788b 100644 (file)
--- a/src/gallium/drivers/r600/evergreen_state.c
+++ b/src/gallium/drivers/r600/evergreen_state.c
@@ -2248,9 +2248,7 @@ static void cayman_init_atom_start_cs(struct r600_context *rctx)
        r600_store_value(cb, 0); /* R_028A3C_VGT_GROUP_VECT_1_FMT_CNTL */
        r600_store_value(cb, 0); /* R_028A40_VGT_GS_MODE */
 
-       r600_store_context_reg_seq(cb, R_028B94_VGT_STRMOUT_CONFIG, 2);
-       r600_store_value(cb, 0); /* R_028B94_VGT_STRMOUT_CONFIG */
-       r600_store_value(cb, 0); /* R_028B98_VGT_STRMOUT_BUFFER_CONFIG */
+       r600_store_context_reg(cb, R_028B98_VGT_STRMOUT_BUFFER_CONFIG, 0);
 
        r600_store_context_reg_seq(cb, R_028AB4_VGT_REUSE_OFF, 2);
        r600_store_value(cb, 0); /* R_028AB4_VGT_REUSE_OFF */
@@ -2809,9 +2807,7 @@ void evergreen_init_atom_start_cs(struct r600_context *rctx)
        r600_store_value(cb, 0);
        r600_store_value(cb, 0);
 
-       r600_store_context_reg_seq(cb, R_028B94_VGT_STRMOUT_CONFIG, 2);
-       r600_store_value(cb, 0); /* R_028B94_VGT_STRMOUT_CONFIG */
-       r600_store_value(cb, 0); /* R_028B98_VGT_STRMOUT_BUFFER_CONFIG */
+       r600_store_context_reg(cb, R_028B98_VGT_STRMOUT_BUFFER_CONFIG, 0);
 
        if (rctx->screen->b.has_streamout) {
                r600_store_context_reg(cb, R_028B28_VGT_STRMOUT_DRAW_OPAQUE_OFFSET, 0);
@@ -3488,6 +3484,7 @@ void evergreen_init_state_functions(struct r600_context *rctx)
        r600_init_atom(rctx, &rctx->stencil_ref.atom, id++, r600_emit_stencil_ref, 4);
        r600_init_atom(rctx, &rctx->vertex_fetch_shader.atom, id++, evergreen_emit_vertex_fetch_shader, 5);
        rctx->atoms[id++] = &rctx->b.streamout.begin_atom;
+       rctx->atoms[id++] = &rctx->b.streamout.enable_atom;
        r600_init_atom(rctx, &rctx->vertex_shader.atom, id++, r600_emit_shader, 23);
        r600_init_atom(rctx, &rctx->pixel_shader.atom, id++, r600_emit_shader, 0);
        r600_init_atom(rctx, &rctx->geometry_shader.atom, id++, r600_emit_shader, 0);

diff --git a/src/gallium/drivers/r600/r600_hw_context.c b/src/gallium/drivers/r600/r600_hw_context.c
index 3d0da2c212f2f778efd9d8cb14930a3297931662..3a3b3d58c15c5130841f6d1afc7d80753c7931e2 100644 (file)
--- a/src/gallium/drivers/r600/r600_hw_context.c
+++ b/src/gallium/drivers/r600/r600_hw_context.c
@@ -311,7 +311,7 @@ void r600_begin_new_cs(struct r600_context *ctx)
                ctx->gs_rings.atom.dirty = true;
        }
        ctx->vertex_shader.atom.dirty = true;
-
+       ctx->b.streamout.enable_atom.dirty = true;
 
        if (ctx->blend_state.cso)
                ctx->blend_state.atom.dirty = true;

diff --git a/src/gallium/drivers/r600/r600_pipe.h b/src/gallium/drivers/r600/r600_pipe.h
index e5bb2b883d5f7c8906f8cf3aa1424e9337e55a76..6d627e5adee73988c957f5939790c85af9888725 100644 (file)
--- a/src/gallium/drivers/r600/r600_pipe.h
+++ b/src/gallium/drivers/r600/r600_pipe.h
@@ -37,7 +37,7 @@
 #include "util/u_double_list.h"
 #include "util/u_transfer.h"
 
-#define R600_NUM_ATOMS 72
+#define R600_NUM_ATOMS 73
 
 /* the number of CS dwords for flushing and drawing */
 #define R600_MAX_FLUSH_CS_DWORDS       16

diff --git a/src/gallium/drivers/r600/r600_state.c b/src/gallium/drivers/r600/r600_state.c
index 6d89e6ce88ba55d330390ed756f4fbe8005eb6eb..e6254c69a2ca6d1c063ee21438b56dd3d13a78e4 100644 (file)
--- a/src/gallium/drivers/r600/r600_state.c
+++ b/src/gallium/drivers/r600/r600_state.c
@@ -2316,8 +2316,7 @@ void r600_init_atom_start_cs(struct r600_context *rctx)
        r600_store_context_reg(cb, R_028AA0_VGT_INSTANCE_STEP_RATE_0, 0);
        r600_store_context_reg(cb, R_028AA4_VGT_INSTANCE_STEP_RATE_1, 0);
 
-       r600_store_context_reg_seq(cb, R_028AB0_VGT_STRMOUT_EN, 3);
-       r600_store_value(cb, 0); /* R_028AB0_VGT_STRMOUT_EN */
+       r600_store_context_reg_seq(cb, R_028AB4_VGT_REUSE_OFF, 2);
        r600_store_value(cb, 1); /* R_028AB4_VGT_REUSE_OFF */
        r600_store_value(cb, 0); /* R_028AB8_VGT_VTX_CNT_EN */
 
@@ -3027,6 +3026,7 @@ void r600_init_state_functions(struct r600_context *rctx)
        r600_init_atom(rctx, &rctx->stencil_ref.atom, id++, r600_emit_stencil_ref, 4);
        r600_init_atom(rctx, &rctx->vertex_fetch_shader.atom, id++, r600_emit_vertex_fetch_shader, 5);
        rctx->atoms[id++] = &rctx->b.streamout.begin_atom;
+       rctx->atoms[id++] = &rctx->b.streamout.enable_atom;
        r600_init_atom(rctx, &rctx->vertex_shader.atom, id++, r600_emit_shader, 23);
        r600_init_atom(rctx, &rctx->pixel_shader.atom, id++, r600_emit_shader, 0);
        r600_init_atom(rctx, &rctx->geometry_shader.atom, id++, r600_emit_shader, 0);

diff --git a/src/gallium/drivers/radeon/r600_pipe_common.h b/src/gallium/drivers/radeon/r600_pipe_common.h
index f858b8c934512b4f214d284f56c6f9b450369ad7..da953a2ef1ee23a0e7eb723b1ceaf5f6a3a24963 100644 (file)
--- a/src/gallium/drivers/radeon/r600_pipe_common.h
+++ b/src/gallium/drivers/radeon/r600_pipe_common.h
@@ -280,6 +280,12 @@ struct r600_streamout {
        /* External state which comes from the vertex shader,
         * it must be set explicitly when binding a shader. */
        unsigned                        *stride_in_dw;
+
+       /* The state of VGT_STRMOUT_(CONFIG|EN). */
+       struct r600_atom                enable_atom;
+       bool                            streamout_enabled;
+       bool                            prims_gen_query_enabled;
+       int                             num_prims_gen_queries;
 };
 
 struct r600_ring {
@@ -416,6 +422,8 @@ void r600_set_streamout_targets(struct pipe_context *ctx,
                                struct pipe_stream_output_target **targets,
                                const unsigned *offset);
 void r600_emit_streamout_end(struct r600_common_context *rctx);
+void r600_update_prims_generated_query_state(struct r600_common_context *rctx,
+                                            unsigned type, int diff);
 void r600_streamout_init(struct r600_common_context *rctx);
 
 /* r600_texture.c */

diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c
index a5d75717797f6ecb3eeaaf9dd6fcf138638e69fa..e9218a2e8ecd4ea68c2f9e72c6efa641c3370ce4 100644 (file)
--- a/src/gallium/drivers/radeon/r600_query.c
+++ b/src/gallium/drivers/radeon/r600_query.c
@@ -152,6 +152,7 @@ static void r600_emit_query_begin(struct r600_common_context *ctx, struct r600_q
        uint64_t va;
 
        r600_update_occlusion_query_state(ctx, query->type, 1);
+       r600_update_prims_generated_query_state(ctx, query->type, 1);
        ctx->need_gfx_cs_space(&ctx->b, query->num_cs_dw * 2, TRUE);
 
        /* Get a new query buffer if needed. */
@@ -284,6 +285,7 @@ static void r600_emit_query_end(struct r600_common_context *ctx, struct r600_que
        }
 
        r600_update_occlusion_query_state(ctx, query->type, -1);
+       r600_update_prims_generated_query_state(ctx, query->type, -1);
 }
 
 static void r600_emit_query_predication(struct r600_common_context *ctx, struct r600_query *query,

diff --git a/src/gallium/drivers/radeon/r600_streamout.c b/src/gallium/drivers/radeon/r600_streamout.c
index d9b1d1c8e5e225eaf1240aa191c0fa2d03a1e21b..cb72ada4aff2a549a6904676311c5e6154acb1da 100644 (file)
--- a/src/gallium/drivers/radeon/r600_streamout.c
+++ b/src/gallium/drivers/radeon/r600_streamout.c
@@ -29,6 +29,8 @@
 
 #include "util/u_memory.h"
 
+static void r600_set_streamout_enable(struct r600_common_context *rctx, bool enable);
+
 static struct pipe_stream_output_target *
 r600_create_so_target(struct pipe_context *ctx,
                      struct pipe_resource *buffer,
@@ -84,11 +86,10 @@ void r600_streamout_buffers_dirty(struct r600_common_context *rctx)
 
        rctx->streamout.num_dw_for_end =
                12 + /* flush_vgt_streamout */
-               num_bufs * 8 + /* STRMOUT_BUFFER_UPDATE */
-               3 /* set_streamout_enable(0) */;
+               num_bufs * 11; /* STRMOUT_BUFFER_UPDATE, BUFFER_SIZE */
 
        begin->num_dw = 12 + /* flush_vgt_streamout */
-                       6; /* set_streamout_enable */
+                       3; /* VGT_STRMOUT_BUFFER_CONFIG */
 
        if (rctx->chip_class >= SI) {
                begin->num_dw += num_bufs * 4; /* SET_CONTEXT_REG */
@@ -105,6 +106,8 @@ void r600_streamout_buffers_dirty(struct r600_common_context *rctx)
                (rctx->family > CHIP_R600 && rctx->family < CHIP_RS780 ? 2 : 0); /* SURFACE_BASE_UPDATE */
 
        begin->dirty = true;
+
+       r600_set_streamout_enable(rctx, true);
 }
 
 void r600_set_streamout_targets(struct pipe_context *ctx,
@@ -144,6 +147,7 @@ void r600_set_streamout_targets(struct pipe_context *ctx,
                r600_streamout_buffers_dirty(rctx);
        } else {
                rctx->streamout.begin_atom.dirty = false;
+               r600_set_streamout_enable(rctx, false);
        }
 }
 
@@ -179,31 +183,6 @@ static void r600_flush_vgt_streamout(struct r600_common_context *rctx)
        radeon_emit(cs, 4); /* poll interval */
 }
 
-static void r600_set_streamout_enable(struct r600_common_context *rctx, unsigned buffer_enable_bit)
-{
-       struct radeon_winsys_cs *cs = rctx->rings.gfx.cs;
-
-       if (buffer_enable_bit) {
-               r600_write_context_reg(cs, R_028AB0_VGT_STRMOUT_EN, S_028AB0_STREAMOUT(1));
-               r600_write_context_reg(cs, R_028B20_VGT_STRMOUT_BUFFER_EN, buffer_enable_bit);
-       } else {
-               r600_write_context_reg(cs, R_028AB0_VGT_STRMOUT_EN, S_028AB0_STREAMOUT(0));
-       }
-}
-
-static void evergreen_set_streamout_enable(struct r600_common_context *rctx, unsigned buffer_enable_bit)
-{
-       struct radeon_winsys_cs *cs = rctx->rings.gfx.cs;
-
-       if (buffer_enable_bit) {
-               r600_write_context_reg_seq(cs, R_028B94_VGT_STRMOUT_CONFIG, 2);
-               radeon_emit(cs, S_028B94_STREAMOUT_0_EN(1)); /* R_028B94_VGT_STRMOUT_CONFIG */
-               radeon_emit(cs, S_028B98_STREAM_0_BUFFER_EN(buffer_enable_bit)); /* R_028B98_VGT_STRMOUT_BUFFER_CONFIG */
-       } else {
-               r600_write_context_reg(cs, R_028B94_VGT_STRMOUT_CONFIG, S_028B94_STREAMOUT_0_EN(0));
-       }
-}
-
 static void r600_emit_streamout_begin(struct r600_common_context *rctx, struct r600_atom *atom)
 {
        struct radeon_winsys_cs *cs = rctx->rings.gfx.cs;
@@ -213,11 +192,10 @@ static void r600_emit_streamout_begin(struct r600_common_context *rctx, struct r
 
        r600_flush_vgt_streamout(rctx);
 
-       if (rctx->chip_class >= EVERGREEN) {
-               evergreen_set_streamout_enable(rctx, rctx->streamout.enabled_mask);
-       } else {
-               r600_set_streamout_enable(rctx, rctx->streamout.enabled_mask);
-       }
+       r600_write_context_reg(cs, rctx->chip_class >= EVERGREEN ?
+                                      R_028B98_VGT_STRMOUT_BUFFER_CONFIG :
+                                      R_028B20_VGT_STRMOUT_BUFFER_EN,
+                              rctx->streamout.enabled_mask);
 
        for (i = 0; i < rctx->streamout.num_targets; i++) {
                if (!t[i])
@@ -321,12 +299,12 @@ void r600_emit_streamout_end(struct r600_common_context *rctx)
 
                r600_emit_reloc(rctx,  &rctx->rings.gfx, t[i]->buf_filled_size,
                                RADEON_USAGE_WRITE, RADEON_PRIO_MIN);
-       }
 
-       if (rctx->chip_class >= EVERGREEN) {
-               evergreen_set_streamout_enable(rctx, 0);
-       } else {
-               r600_set_streamout_enable(rctx, 0);
+               /* Zero the buffer size. The counters (primitives generated,
+                * primitives emitted) may be enabled even if there is not
+                * buffer bound. This ensures that the primitives-emitted query
+                * won't increment. */
+               r600_write_context_reg(cs, R_028AD0_VGT_STRMOUT_BUFFER_SIZE_0 + 16*i, 0);
        }
 
        rctx->streamout.begin_emitted = false;
@@ -338,9 +316,60 @@ void r600_emit_streamout_end(struct r600_common_context *rctx)
        }
 }
 
+/* STREAMOUT CONFIG DERIVED STATE
+ *
+ * Streamout must be enabled for the PRIMITIVES_GENERATED query to work.
+ * The buffer mask is an independent state, so no writes occur if there
+ * are no buffers bound.
+ */
+
+static bool r600_get_strmout_en(struct r600_common_context *rctx)
+{
+       return rctx->streamout.streamout_enabled ||
+              rctx->streamout.prims_gen_query_enabled;
+}
+
+static void r600_emit_streamout_enable(struct r600_common_context *rctx,
+                                      struct r600_atom *atom)
+{
+       r600_write_context_reg(rctx->rings.gfx.cs,
+                              rctx->chip_class >= EVERGREEN ?
+                                      R_028B94_VGT_STRMOUT_CONFIG :
+                                      R_028AB0_VGT_STRMOUT_EN,
+                              S_028B94_STREAMOUT_0_EN(r600_get_strmout_en(rctx)));
+}
+
+static void r600_set_streamout_enable(struct r600_common_context *rctx, bool enable)
+{
+       bool old_strmout_en = r600_get_strmout_en(rctx);
+
+       rctx->streamout.streamout_enabled = enable;
+       if (old_strmout_en != r600_get_strmout_en(rctx))
+               rctx->streamout.enable_atom.dirty = true;
+}
+
+void r600_update_prims_generated_query_state(struct r600_common_context *rctx,
+                                            unsigned type, int diff)
+{
+       if (type == PIPE_QUERY_PRIMITIVES_GENERATED) {
+               bool old_strmout_en = r600_get_strmout_en(rctx);
+
+               rctx->streamout.num_prims_gen_queries += diff;
+               assert(rctx->streamout.num_prims_gen_queries >= 0);
+
+               rctx->streamout.prims_gen_query_enabled =
+                       rctx->streamout.num_prims_gen_queries != 0;
+
+               if (old_strmout_en != r600_get_strmout_en(rctx))
+                       rctx->streamout.enable_atom.dirty = true;
+       }
+}
+
 void r600_streamout_init(struct r600_common_context *rctx)
 {
        rctx->b.create_stream_output_target = r600_create_so_target;
        rctx->b.stream_output_target_destroy = r600_so_target_destroy;
        rctx->streamout.begin_atom.emit = r600_emit_streamout_begin;
+       rctx->streamout.enable_atom.emit = r600_emit_streamout_enable;
+       rctx->streamout.enable_atom.num_dw = 3;
 }

diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c b/src/gallium/drivers/radeonsi/si_hw_context.c
index 21a683ff5f76023a40f7d263e9e02f1c2013e0cf..c952c8d31f70517bc536a6cccbf4879597dfeefc 100644 (file)
--- a/src/gallium/drivers/radeonsi/si_hw_context.c
+++ b/src/gallium/drivers/radeonsi/si_hw_context.c
@@ -177,6 +177,7 @@ void si_begin_new_cs(struct si_context *ctx)
        }
 
        ctx->framebuffer.atom.dirty = true;
+       ctx->b.streamout.enable_atom.dirty = true;
        si_all_descriptors_begin_new_cs(ctx);
 
        ctx->b.initial_gfx_cs_size = ctx->b.rings.gfx.cs->cdw;

diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
index 95f022be8744632a592e05b4befa33a17c8f5650..0efd4ebcb85526feab21da1764e1c4b8848c51cc 100644 (file)
--- a/src/gallium/drivers/radeonsi/si_pipe.c
+++ b/src/gallium/drivers/radeonsi/si_pipe.c
@@ -148,6 +148,7 @@ static struct pipe_context *si_create_context(struct pipe_screen *screen, void *
        sctx->atoms.cache_flush = &sctx->cache_flush;
 
        sctx->atoms.streamout_begin = &sctx->b.streamout.begin_atom;
+       sctx->atoms.streamout_enable = &sctx->b.streamout.enable_atom;
 
        switch (sctx->b.chip_class) {
        case SI:

diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.h
index e8aa13e2df8d247aaae8afa8c637182313227969..47dc8e754eeda24fcb93428f4d63234182a93aa7 100644 (file)
--- a/src/gallium/drivers/radeonsi/si_pipe.h
+++ b/src/gallium/drivers/radeonsi/si_pipe.h
@@ -108,6 +108,7 @@ struct si_context {
                         * updated in memory. */
                        struct r600_atom *cache_flush;
                        struct r600_atom *streamout_begin;
+                       struct r600_atom *streamout_enable; /* must be after streamout_begin */
                        struct r600_atom *framebuffer;
                };
                struct r600_atom *array[0];

diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
index b012d0991c1623ed523338325b01fbd23c014c3f..8dd2885f70b234f3d5c0d346117980f26f38002d 100644 (file)
--- a/src/gallium/drivers/radeonsi/si_state.c
+++ b/src/gallium/drivers/radeonsi/si_state.c
@@ -3064,7 +3064,6 @@ void si_init_config(struct si_context *sctx)
        si_pm4_set_reg(pm4, R_028B68_VGT_GS_VERT_ITEMSIZE_3, 0);
        si_pm4_set_reg(pm4, R_028B90_VGT_GS_INSTANCE_CNT, 0);
 
-       si_pm4_set_reg(pm4, R_028B94_VGT_STRMOUT_CONFIG, 0x0);
        si_pm4_set_reg(pm4, R_028B98_VGT_STRMOUT_BUFFER_CONFIG, 0x0);
        if (sctx->b.chip_class == SI) {
                si_pm4_set_reg(pm4, R_028AA8_IA_MULTI_VGT_PARAM,