ipa: do not DECL_IS_MALLOC for void fns
authorMartin Liska <mliska@suse.cz>
Wed, 2 Dec 2020 12:01:47 +0000 (13:01 +0100)
committerMartin Liska <mliska@suse.cz>
Wed, 2 Dec 2020 14:03:26 +0000 (15:03 +0100)
gcc/ChangeLog:

PR ipa/98075
* cgraph.c (cgraph_node::dump): Dump decl_is_malloc flag.
* ipa-pure-const.c (propagate_malloc): Do not set malloc
attribute for void functions.

gcc/testsuite/ChangeLog:

PR ipa/98075
* g++.dg/ipa/pr98075.C: New test.

gcc/cgraph.c
gcc/ipa-pure-const.c
gcc/testsuite/g++.dg/ipa/pr98075.C [new file with mode: 0644]

index dbde8aaaba12a6120c36c4a96f00bc19b9886612..cb59a5a71fc0d18687697739a4f157f159c063b2 100644 (file)
@@ -2190,6 +2190,8 @@ cgraph_node::dump (FILE *f)
     fprintf (f, " optimize_size");
   if (parallelized_function)
     fprintf (f, " parallelized_function");
+  if (DECL_IS_MALLOC (decl))
+    fprintf (f, " decl_is_malloc");
   if (DECL_IS_OPERATOR_NEW_P (decl))
     fprintf (f, " %soperator_new",
             DECL_IS_REPLACEABLE_OPERATOR (decl) ? "replaceable_" : "");
index 054f35981a5d21ffbbbec105307a8f6b432d6096..4c47eec8509dead50e0cf3ba264e74408d42a1ee 100644 (file)
@@ -1973,7 +1973,8 @@ propagate_malloc (void)
        funct_state l = funct_state_summaries->get (node);
        if (!node->alias
            && l->malloc_state == STATE_MALLOC
-           && !node->inlined_to)
+           && !node->inlined_to
+           && !VOID_TYPE_P (TREE_TYPE (TREE_TYPE (node->decl))))
          {
            if (dump_file && (dump_flags & TDF_DETAILS))
              fprintf (dump_file, "Function %s found to be malloc\n",
diff --git a/gcc/testsuite/g++.dg/ipa/pr98075.C b/gcc/testsuite/g++.dg/ipa/pr98075.C
new file mode 100644 (file)
index 0000000..0c4219d
--- /dev/null
@@ -0,0 +1,30 @@
+/* PR ipa/98075 */
+/* { dg-do compile } */                                                                        
+/* { dg-options "-O2 -fno-inline" } */
+
+template <typename BS>
+class xg {
+public:
+  BS *
+  fw ()
+  {
+    return static_cast<BS *> (operator new (sizeof (BS)));
+  }
+};
+
+class zp : xg<int> {
+public:
+  __attribute__ ((always_inline)) zp ()
+  {
+    hy = xg<int>::fw ();
+  }
+
+private:
+  int *hy;
+};
+
+void
+e5 ()
+{
+  zp ix;
+}