PR24144, pdp11-ld overwriting section data with zeros

bfd/
	PR 24144
	* pdp11.c (set_section_contents): Revert 2015-02-24 change.
gas/
	PR 24144
	* config/obj-aout.c (obj_aout_frob_file_before_fix): Write to end
	of section to ensure file contents cover aligned section size.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index ce088c96cdab1e82dc670bd0f24c2c763f2aece8..e206629bd763f346a601e116ff527760b10baa97 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2019-02-24  Alan Modra  <amodra@gmail.com>
+
+       PR 24144
+       * pdp11.c (set_section_contents): Revert 2015-02-24 change.
+
 2019-02-20  Eric Tsai  <erictsai@cadence.com>
 
        * elf32-xtensa.c (is_resolvable_asm_expansion): Scan output

diff --git a/bfd/pdp11.c b/bfd/pdp11.c
index a46775a4edd77cfaad580a9165b5e38dd6f667d4..b16c78f9399b606c975d55fea7a6c91cfbc648e1 100644 (file)
--- a/bfd/pdp11.c
+++ b/bfd/pdp11.c
@@ -1146,14 +1146,6 @@ NAME (aout, set_section_contents) (bfd *abfd,
       if (bfd_seek (abfd, section->filepos + offset, SEEK_SET) != 0
          || bfd_bwrite (location, count, abfd) != count)
        return FALSE;
-
-      /* If necessary, pad the section to its aligned size.  */
-      if ((section == obj_datasec (abfd)
-          || section == obj_textsec (abfd))
-         && count < section->size
-         && (bfd_seek (abfd, section->filepos + offset + section->size - 1, SEEK_SET) != 0
-             || bfd_bwrite ("", 1, abfd) != 1))
-       return FALSE;
     }
 
   return TRUE;

diff --git a/gas/ChangeLog b/gas/ChangeLog
index a301c047f1ca31039c18eee1d48b2b2d802f923d..03c9b4e9aec16990b0844d9fb4a0711d95c6f55c 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,9 @@
+2019-02-24  Alan Modra  <amodra@gmail.com>
+
+       PR 24144
+       * config/obj-aout.c (obj_aout_frob_file_before_fix): Write to end
+       of section to ensure file contents cover aligned section size.
+
 2019-02-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
        * config/tc-arm.c (arm_cpus): Add neoverse-n1.

diff --git a/gas/config/obj-aout.c b/gas/config/obj-aout.c
index 22e103b1e3d8b1fd10a84c015b7bc3d3abf9dbe1..03e0ef3c0a481eef0deceebaf241fb72aa7f60f3 100644 (file)
--- a/gas/config/obj-aout.c
+++ b/gas/config/obj-aout.c
@@ -118,17 +118,27 @@ obj_aout_frob_file_before_fix (void)
 {
   /* Relocation processing may require knowing the VMAs of the sections.
      Since writing to a section will cause the BFD back end to compute the
-     VMAs, fake it out here....  */
-  bfd_byte b = 0;
-  bfd_boolean x = TRUE;
-  if (bfd_section_size (stdoutput, text_section) != 0)
-    x = bfd_set_section_contents (stdoutput, text_section, &b, (file_ptr) 0,
-                                 (bfd_size_type) 1);
-  else if (bfd_section_size (stdoutput, data_section) != 0)
-    x = bfd_set_section_contents (stdoutput, data_section, &b, (file_ptr) 0,
-                                 (bfd_size_type) 1);
-
-  gas_assert (x);
+     VMAs, fake it out here....
+     Writing to the end of the section ensures the file contents
+     extend to cover the entire aligned size.  We possibly won't know
+     the aligned size until after VMAs and sizes are set on the first
+     bfd_set_section_contents call, so it might be necessary to repeat.  */
+  asection *sec = NULL;
+  if (data_section->size != 0)
+    sec = data_section;
+  else if (text_section->size != 0)
+    sec = text_section;
+  if (sec)
+    {
+      bfd_size_type size;
+      do
+       {
+         bfd_byte b = 0;
+         size = sec->size;
+         gas_assert (bfd_set_section_contents (stdoutput, sec, &b,
+                                               size - 1, (bfd_size_type) 1));
+       } while (size != sec->size);
+    }
 }
 
 static void